Sync from fork #74

Merged
0xmuralik merged 232 commits from murali/update-fork into main 2023-01-10 04:50:57 +00:00
0xmuralik commented 2023-01-05 12:05:19 +00:00 (Migrated from github.com)

Closes: #72

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺ v ✰ Thanks for creating a PR! ✰ v Before smashing the submit button please review the checkboxes. v If a checkbox is n/a - please still include it but + a little note why ☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --> Closes: #72 ## Description <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> ______ For contributor use: - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer ______ For admin use: - [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc) - [ ] Reviewers assigned - [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))
roysc reviewed 2023-01-05 12:05:19 +00:00
codecov-commenter commented 2023-01-06 06:41:52 +00:00 (Migrated from github.com)

Codecov Report

Merging #74 (51aa603) into main (fac5a95) will increase coverage by 8.12%.
The diff coverage is 68.96%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   58.44%   66.57%   +8.12%     
==========================================
  Files         142      145       +3     
  Lines       15644    15953     +309     
==========================================
+ Hits         9143    10620    +1477     
+ Misses       6147     4859    -1288     
- Partials      354      474     +120     
Impacted Files Coverage Δ
indexer/kv_indexer.go 64.96% <0.00%> (ø)
rpc/backend/backend.go 76.47% <ø> (+29.80%) ⬆️
rpc/backend/filters.go 100.00% <ø> (+100.00%) ⬆️
rpc/backend/node_info.go 46.51% <0.00%> (+46.51%) ⬆️
rpc/types/events.go 71.85% <ø> (ø)
rpc/types/utils.go 0.00% <0.00%> (ø)
types/chain_id.go 84.21% <ø> (ø)
types/int.go 41.66% <ø> (ø)
types/validation.go 100.00% <ø> (ø)
x/auction/client/testutil/common.go 100.00% <ø> (ø)
... and 74 more
# [Codecov](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#74](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (51aa603) into [main](https://codecov.io/gh/cerc-io/laconicd/commit/fac5a956797612ed8d6f3a43a59b27809fb50a74?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (fac5a95) will **increase** coverage by `8.12%`. > The diff coverage is `68.96%`. <details><summary>Additional details and impacted files</summary> [![Impacted file tree graph](https://codecov.io/gh/cerc-io/laconicd/pull/74/graphs/tree.svg?width=650&height=150&src=pr&token=5tWmn7LxfO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #74 +/- ## ========================================== + Coverage 58.44% 66.57% +8.12% ========================================== Files 142 145 +3 Lines 15644 15953 +309 ========================================== + Hits 9143 10620 +1477 + Misses 6147 4859 -1288 - Partials 354 474 +120 ``` | [Impacted Files](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [indexer/kv\_indexer.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW5kZXhlci9rdl9pbmRleGVyLmdv) | `64.96% <0.00%> (ø)` | | | [rpc/backend/backend.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvYmFja2VuZC5nbw==) | `76.47% <ø> (+29.80%)` | :arrow_up: | | [rpc/backend/filters.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvZmlsdGVycy5nbw==) | `100.00% <ø> (+100.00%)` | :arrow_up: | | [rpc/backend/node\_info.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL2JhY2tlbmQvbm9kZV9pbmZvLmdv) | `46.51% <0.00%> (+46.51%)` | :arrow_up: | | [rpc/types/events.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL3R5cGVzL2V2ZW50cy5nbw==) | `71.85% <ø> (ø)` | | | [rpc/types/utils.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-cnBjL3R5cGVzL3V0aWxzLmdv) | `0.00% <0.00%> (ø)` | | | [types/chain\_id.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dHlwZXMvY2hhaW5faWQuZ28=) | `84.21% <ø> (ø)` | | | [types/int.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dHlwZXMvaW50Lmdv) | `41.66% <ø> (ø)` | | | [types/validation.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dHlwZXMvdmFsaWRhdGlvbi5nbw==) | `100.00% <ø> (ø)` | | | [x/auction/client/testutil/common.go](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-eC9hdWN0aW9uL2NsaWVudC90ZXN0dXRpbC9jb21tb24uZ28=) | `100.00% <ø> (ø)` | | | ... and [74 more](https://codecov.io/gh/cerc-io/laconicd/pull/74?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | | </details>
0xmuralik commented 2023-01-06 10:49:38 +00:00 (Migrated from github.com)

Failing tests:
Protobuf: just a warning to indicate changes in proto files
Semgrep: mutex lock released in cleanup func. This warning can be ignored.
Dependecy review: few import in ethermint contain vulnerabilities.

Failing tests: Protobuf: just a warning to indicate changes in proto files Semgrep: mutex lock released in cleanup func. This warning can be ignored. Dependecy review: few import in ethermint contain vulnerabilities.
i-norden approved these changes 2023-01-09 18:29:28 +00:00
i-norden left a comment
Member

LGTM! I appreciate the quick turn around on such a large rebase/refactor. And thanks for explaining the failing actions, that all checks out, the flagged JS is only being used in solidity test suites so I'm not worried about that. We should still come back and tidy this up in a separate issue.

LGTM! I appreciate the quick turn around on such a large rebase/refactor. And thanks for explaining the failing actions, that all checks out, the flagged JS is only being used in solidity test suites so I'm not worried about that. We should still come back and tidy this up in a separate issue.
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#74
No description provided.