fix: rollback to tendermint v0.34.21 #38
No reviewers
Labels
No Label
bug
C:CLI
C:Crypto
C:Encoding
C:Proto
C:Types
dependencies
docker
documentation
duplicate
enhancement
go
good first issue
help wanted
high priority
in progress
invalid
javascript
low priority
medium priority
question
Status: Stale
Type: ADR
Type: Build
Type: CI
Type: Docs
Type: Tests
urgent
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/laconicd-deprecated#38
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "murali/tendermint-rollback"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes: #37
Description
Rollback to tendermint by taking https://github.com/evmos/ethermint as reference
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)LGTM on first pass but some of the tests are failing which weren't before. Need to take a closer look: tests need to be fixed, or need to convinced it is not an issue.
@ -205,4 +211,3 @@
sigs.k8s.io/yaml v1.3.0 // indirect
)
replace (
Let's remove these commented out replaces
@ -40,35 +42,36 @@ func startInProcess(cfg Config, val *Validator) error {
return err
}
Let's remove these commented out lines
Hi @0xmuralik, what is the status on this? Can you please get the remaining tests passing on this so that we can merge, thanks!
@ -0,0 +384,4 @@
msg,
common.BytesToHash(block.Block.Hash()),
uint64(block.Block.Height),
uint64(idx),
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
@ -0,0 +151,4 @@
b.logger.Debug("failed to decode transaction in block", "height", blockHeight, "error", err.Error())
continue
}
txGasUsed := uint64(eachTendermintTxResult.GasUsed)
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
@ -0,0 +178,4 @@
sumGasUsed := sorter[0].gasUsed
for i, p := range rewardPercentiles {
thresholdGasUsed := uint64(blockGasUsed * p / 100)
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
@ -0,0 +383,4 @@
return rpctypes.NewTransactionFromMsg(
msg,
common.BytesToHash(block.Block.Hash()),
uint64(block.Block.Height),
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
@ -0,0 +364,4 @@
return nil, nil
}
} else {
i := int(idx)
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
@ -0,0 +348,4 @@
var msg *evmtypes.MsgEthereumTx
// find in tx indexer
res, err := b.GetTxByTxIndex(block.Block.Height, uint(idx))
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
Show more details
Hey @0xmuralik, looks good, but it's not really feasible for me to review a change set this large line-by-line. So I think what would help the most is if you can get the remaining github actions passing or provide an explanation for why it is okay for them not to be passing (in which case we eventually need to adjust the actions or tests so that they do all pass). Thanks!
Hey @i-norden, Most of the failing tests from gosec and lint are false postives and very few need to be addressed. We can add comments to ignore these errors. I suggesting addressing these in a different PR.
And the protobuf breaking test is just to mention the changes in proto files; nothing to worry about.
@0xmuralik are the failing
test-solidity
s an artifact of the CI? 1-3 is passing but 2-3, and 3-3 are not.RangeError: Maximum call stack size exceeded
same error appears on laconicd main and ethermint main. These were failing before too. May be there is a limit on compiled contracts we an use in a test or something like that. Nothing to worry afaik.@ -0,0 +120,4 @@
for i := 0; i < n; i++ {
// don't need that much entropy for simulation
privkeySeed := make([]byte, 15)
_, _ = r.Read(privkeySeed)
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
@ -0,0 +124,4 @@
prv := secp256k1.GenPrivKeyFromSecret(privkeySeed)
ethPrv := ðsecp256k1.PrivKey{}
_ = ethPrv.UnmarshalAmino(prv.Bytes()) // UnmarshalAmino simply copies the bytes and assigns them to ethPrv.Key
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
@ -0,0 +228,4 @@
if args.Nonce == nil {
// get the nonce from the account retriever
// ignore error in case tge account doesn't exist yet
nonce, _ := b.getAccountNonce(*args.From, true, 0, b.logger)
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
@ -0,0 +89,4 @@
// CurrentHeader returns the latest block header
func (b *Backend) CurrentHeader() *ethtypes.Header {
header, _ := b.HeaderByNumber(rpctypes.EthLatestBlockNumber)
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
@ -0,0 +134,4 @@
return nil, err
}
address, _ := sdk.AccAddressFromBech32(res.AccountAddress)
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
@ -0,0 +198,4 @@
}
// ignore error as we only care about the length of the list
list, _ := b.clientCtx.Keyring.List()
Returned error is not propagated up the stack.
Returned error is not propagated up the stack.
Show more details
LGTM