Fix progressively increasing gas usage #146

Merged
ashwin merged 4 commits from deep-stack/laconicd-deprecated:pm-registry-hot-fix into main 2024-04-03 12:14:50 +00:00
Member

Part of https://www.notion.so/Set-constant-gas-price-in-laconicd-00b470964f0e4020b06153f0f2c9bcfb

  • Use custom KV store gas config (0 gas for KV store ops) for laconic module (auction, bond, registry) txs
  • Log gas consumed for laconic module txs
  • Handle lint errors
    • Latest version of golangci-lint gets used in the linter CI
    • After the recent release (v1.57.2), it had started throwing some new lint errors (see failing run)
    • Disable dupl rule as it was throwing false positives
Part of https://www.notion.so/Set-constant-gas-price-in-laconicd-00b470964f0e4020b06153f0f2c9bcfb - Use custom KV store gas config (0 gas for KV store ops) for laconic module (auction, bond, registry) txs - Log gas consumed for laconic module txs - Handle lint errors - Latest version of `golangci-lint` gets used in the linter CI - After the recent release ([v1.57.2](https://github.com/golangci/golangci-lint/releases/tag/v1.57.2)), it had started throwing some new lint errors (see [failing run](https://git.vdb.to/cerc-io/laconicd/actions/runs/628/jobs/0)) - Disable `dupl` rule as it was throwing [false positives](https://stackoverflow.com/questions/71611375/how-to-avoid-go-lint-duplication-for-same-pattern-with-different-function)
prathamesh added 2 commits 2024-04-03 06:37:30 +00:00
Use custom KV store gas config for all laconic txs
Some checks failed
Deploy Contract / deploy (pull_request) Successful in 1m25s
Build / build (pull_request) Successful in 2m25s
Tests / test-rpc (pull_request) Successful in 5m47s
Tests / test-importer (pull_request) Successful in 16m25s
Tests / test-unit (pull_request) Successful in 6m43s
Tests / sdk_tests (pull_request) Successful in 9m36s
Lint / Run golangci-lint (pull_request) Failing after 4m21s
Lint / Run flake8 on python integration tests (pull_request) Successful in 1m43s
ea30697b50
prathamesh changed title from [WIP] Handle increasing gas for successive write txs in laconic modules to [WIP] Handle increasing gas for consecutive write txs in laconic modules 2024-04-03 06:40:00 +00:00
prathamesh changed title from [WIP] Handle increasing gas for consecutive write txs in laconic modules to [WIP] Fix progressively increasing gas usage 2024-04-03 06:46:12 +00:00
prathamesh added 2 commits 2024-04-03 09:10:14 +00:00
Handle lint errors
All checks were successful
Deploy Contract / deploy (pull_request) Successful in 1m13s
Lint / Run flake8 on python integration tests (pull_request) Successful in 2m3s
Build / build (pull_request) Successful in 2m49s
Lint / Run golangci-lint (pull_request) Successful in 5m8s
Tests / test-rpc (pull_request) Successful in 5m38s
Tests / sdk_tests (pull_request) Successful in 10m14s
Tests / test-importer (pull_request) Successful in 17m5s
Tests / test-unit (pull_request) Successful in 6m24s
21675b4574
prathamesh changed title from [WIP] Fix progressively increasing gas usage to Fix progressively increasing gas usage 2024-04-03 12:01:30 +00:00
ashwin merged commit 322d6f188b into main 2024-04-03 12:14:50 +00:00
ashwin deleted branch pm-registry-hot-fix 2024-04-03 12:14:50 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#146
No description provided.