Add DnsRecord and ApplicationDeploymentRequest #124

Merged

telackey merged 1 commits from telackey/dns into main 2023-12-07 22:19:11 +00:00

Conversation 0 Commits 1 Files Changed 5

+1402 -135

telackey commented 2023-12-07 21:47:46 +00:00

Contributor

Copy Link

Copy Source

Note: This has a breaking protobuf change, but that is known and OK, as the previous release has not been deployed externally.

message DnsRecord {
  string type           = 1 [(gogoproto.moretags) = "json:\"type\" yaml:\"type\""];
  string name           = 2 [(gogoproto.moretags) = "json:\"name\" yaml:\"name\""];
  string version        = 3 [(gogoproto.moretags) = "json:\"version\" yaml:\"version\""];
  string resource_type  = 4 [(gogoproto.moretags) = "json:\"resourceType\" yaml:\"resourceType\""];
  string value          = 5 [(gogoproto.moretags) = "json:\"value\" yaml:\"value\""];
  string meta           = 20 [(gogoproto.moretags) = "json:\"meta\" yaml:\"meta\""];
  repeated string tags  = 21 [(gogoproto.moretags) = "json:\"tags\" yaml:\"tags\""];
}

message ApplicationDeploymentRequest {
  string type           = 1 [(gogoproto.moretags) = "json:\"type\" yaml:\"type\""];
  string name           = 2 [(gogoproto.moretags) = "json:\"name\" yaml:\"name\""];
  string version        = 3 [(gogoproto.moretags) = "json:\"version\" yaml:\"version\""];
  string application    = 4 [(gogoproto.moretags) = "json:\"application\" yaml:\"application\""];
  string dns            = 5 [(gogoproto.moretags) = "json:\"dns\" yaml:\"dns\""];
  string config         = 6 [(gogoproto.moretags) = "json:\"config\" yaml:\"config\""];
  repeated string crn   = 7 [(gogoproto.moretags) = "json:\"crn\" yaml:\"crn\""];
  string meta           = 20 [(gogoproto.moretags) = "json:\"meta\" yaml:\"meta\""];
  repeated string tags  = 21 [(gogoproto.moretags) = "json:\"tags\" yaml:\"tags\""];
}

Also rename WebAppDeploymentRecord to ApplicationDeploymentRecord.

> Note: This has a breaking protobuf change, but that is known and OK, as the previous release has not been deployed externally. ``` message DnsRecord { string type = 1 [(gogoproto.moretags) = "json:\"type\" yaml:\"type\""]; string name = 2 [(gogoproto.moretags) = "json:\"name\" yaml:\"name\""]; string version = 3 [(gogoproto.moretags) = "json:\"version\" yaml:\"version\""]; string resource_type = 4 [(gogoproto.moretags) = "json:\"resourceType\" yaml:\"resourceType\""]; string value = 5 [(gogoproto.moretags) = "json:\"value\" yaml:\"value\""]; string meta = 20 [(gogoproto.moretags) = "json:\"meta\" yaml:\"meta\""]; repeated string tags = 21 [(gogoproto.moretags) = "json:\"tags\" yaml:\"tags\""]; } message ApplicationDeploymentRequest { string type = 1 [(gogoproto.moretags) = "json:\"type\" yaml:\"type\""]; string name = 2 [(gogoproto.moretags) = "json:\"name\" yaml:\"name\""]; string version = 3 [(gogoproto.moretags) = "json:\"version\" yaml:\"version\""]; string application = 4 [(gogoproto.moretags) = "json:\"application\" yaml:\"application\""]; string dns = 5 [(gogoproto.moretags) = "json:\"dns\" yaml:\"dns\""]; string config = 6 [(gogoproto.moretags) = "json:\"config\" yaml:\"config\""]; repeated string crn = 7 [(gogoproto.moretags) = "json:\"crn\" yaml:\"crn\""]; string meta = 20 [(gogoproto.moretags) = "json:\"meta\" yaml:\"meta\""]; repeated string tags = 21 [(gogoproto.moretags) = "json:\"tags\" yaml:\"tags\""]; } ``` Also rename WebAppDeploymentRecord to ApplicationDeploymentRecord.

telackey added 1 commit 2023-12-07 21:47:46 +00:00

Add DnsRecord and ApplicationDeploymentRequest bfcb84eb3e

telackey requested review from dboreham 2023-12-07 22:19:03 +00:00

telackey merged commit 47d086111d into main 2023-12-07 22:19:11 +00:00

telackey referenced this issue from a commit 2023-12-07 22:19:15 +00:00

Add DnsRecord and ApplicationDeploymentRequest (#124)

Sign in to join this conversation.

Reviewers

No Reviewers

dboreham

Labels

Clear labels

C:CLI

C:Crypto

C:Encoding

C:Proto

C:Types

Status: Stale

Type: ADR

Type: Build

Type: CI

Type: Docs

Type: Tests

bug

Something isn't working

dependencies

Pull requests that update a dependency file

docker

Pull requests that update Docker code

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

go

Pull requests that update Go code

good first issue

Good for newcomers

help wanted

Extra attention is needed

high priority

in progress

currently working on

invalid

This doesn't seem right

javascript

Pull requests that update Javascript code

low priority

medium priority

question

Further information is requested

urgent

Top priority issue

wontfix

This will not be worked on

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) iskay prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconicd-deprecated#124