evm: improve test coverage of statedb package (#888)

Closes: #876
- coverage: 99.3% of statements
This commit is contained in:
yihuang 2022-01-07 01:10:51 +08:00 committed by GitHub
parent f5b61e914e
commit e6c9b7723b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 598 additions and 303 deletions

View File

@ -54,23 +54,6 @@ func newAccessList() *accessList {
}
}
// Copy creates an independent copy of an accessList.
func (al *accessList) Copy() *accessList {
cp := newAccessList()
for k, v := range al.addresses {
cp.addresses[k] = v
}
cp.slots = make([]map[common.Hash]struct{}, len(al.slots))
for i, slotMap := range al.slots {
newSlotmap := make(map[common.Hash]struct{}, len(slotMap))
for k := range slotMap {
newSlotmap[k] = struct{}{}
}
cp.slots[i] = newSlotmap
}
return cp
}
// AddAddress adds an address to the access list, and returns 'true' if the operation
// caused a change (addr was not previously in the list).
func (al *accessList) AddAddress(address common.Address) bool {

View File

@ -1,29 +1,35 @@
package statedb_test
import (
"bytes"
"errors"
"math/big"
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/crypto"
"github.com/tharsis/ethermint/x/evm/statedb"
)
var _ statedb.Keeper = &MockKeeper{}
var (
_ statedb.Keeper = &MockKeeper{}
errAddress common.Address = common.BigToAddress(big.NewInt(100))
emptyCodeHash = crypto.Keccak256(nil)
)
type MockAcount struct {
account statedb.Account
states statedb.Storage
}
type MockKeeper struct {
errAddress common.Address
accounts map[common.Address]statedb.Account
states map[common.Address]statedb.Storage
accounts map[common.Address]MockAcount
codes map[common.Hash][]byte
}
func NewMockKeeper() *MockKeeper {
return &MockKeeper{
errAddress: common.BigToAddress(big.NewInt(1)),
accounts: make(map[common.Address]statedb.Account),
states: make(map[common.Address]statedb.Storage),
accounts: make(map[common.Address]MockAcount),
codes: make(map[common.Hash][]byte),
}
}
@ -33,11 +39,11 @@ func (k MockKeeper) GetAccount(ctx sdk.Context, addr common.Address) *statedb.Ac
if !ok {
return nil
}
return &acct
return &acct.account
}
func (k MockKeeper) GetState(ctx sdk.Context, addr common.Address, key common.Hash) common.Hash {
return k.states[addr][key]
return k.accounts[addr].states[key]
}
func (k MockKeeper) GetCode(ctx sdk.Context, codeHash common.Hash) []byte {
@ -45,23 +51,37 @@ func (k MockKeeper) GetCode(ctx sdk.Context, codeHash common.Hash) []byte {
}
func (k MockKeeper) ForEachStorage(ctx sdk.Context, addr common.Address, cb func(key, value common.Hash) bool) {
for k, v := range k.states[addr] {
if acct, ok := k.accounts[addr]; ok {
for k, v := range acct.states {
if !cb(k, v) {
return
}
}
}
}
func (k MockKeeper) SetAccount(ctx sdk.Context, addr common.Address, account statedb.Account) error {
k.accounts[addr] = account
if addr == errAddress {
return errors.New("mock db error")
}
acct, exists := k.accounts[addr]
if exists {
// update
acct.account = account
k.accounts[addr] = acct
} else {
k.accounts[addr] = MockAcount{account: account, states: make(statedb.Storage)}
}
return nil
}
func (k MockKeeper) SetState(ctx sdk.Context, addr common.Address, key common.Hash, value []byte) {
if acct, ok := k.accounts[addr]; ok {
if len(value) == 0 {
delete(k.states[addr], key)
delete(acct.states, key)
} else {
k.states[addr][key] = common.BytesToHash(value)
acct.states[key] = common.BytesToHash(value)
}
}
}
@ -70,11 +90,25 @@ func (k MockKeeper) SetCode(ctx sdk.Context, codeHash []byte, code []byte) {
}
func (k MockKeeper) DeleteAccount(ctx sdk.Context, addr common.Address) error {
if addr == errAddress {
return errors.New("mock db error")
}
old := k.accounts[addr]
delete(k.accounts, addr)
delete(k.states, addr)
if len(old.CodeHash) > 0 {
delete(k.codes, common.BytesToHash(old.CodeHash))
if !bytes.Equal(old.account.CodeHash, emptyCodeHash) {
delete(k.codes, common.BytesToHash(old.account.CodeHash))
}
return nil
}
func (k MockKeeper) Clone() *MockKeeper {
accounts := make(map[common.Address]MockAcount, len(k.accounts))
for k, v := range k.accounts {
accounts[k] = v
}
codes := make(map[common.Hash][]byte, len(k.codes))
for k, v := range k.codes {
codes[k] = v
}
return &MockKeeper{accounts, codes}
}

View File

@ -124,9 +124,6 @@ func (s *stateObject) setBalance(amount *big.Int) {
s.account.Balance = amount
}
// Return the gas back to the origin. Used by the Virtual machine or Closures
func (s *stateObject) ReturnGas(gas *big.Int) {}
//
// Attribute accessors
//

View File

@ -70,11 +70,6 @@ func (s *StateDB) Keeper() Keeper {
return s.keeper
}
// Context returns the embedded `sdk.Context`
func (s *StateDB) Context() sdk.Context {
return s.ctx
}
// AddLog adds a log, called by evm.
func (s *StateDB) AddLog(log *ethtypes.Log) {
s.journal.append(addLogChange{})
@ -139,16 +134,6 @@ func (s *StateDB) GetNonce(addr common.Address) uint64 {
return 0
}
// TxIndex returns the current transaction index.
func (s *StateDB) TxIndex() uint {
return s.txConfig.TxIndex
}
// BlockHash returns the current block hash.
func (s *StateDB) BlockHash() common.Hash {
return s.txConfig.BlockHash
}
// GetCode returns the code of account, nil if not exists.
func (s *StateDB) GetCode(addr common.Address) []byte {
stateObject := s.getStateObject(addr)

View File

@ -7,275 +7,571 @@ import (
sdk "github.com/cosmos/cosmos-sdk/types"
"github.com/ethereum/go-ethereum/common"
ethtypes "github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/core/vm"
"github.com/ethereum/go-ethereum/crypto"
"github.com/stretchr/testify/suite"
"github.com/tharsis/ethermint/x/evm/statedb"
)
var (
address common.Address = common.BigToAddress(big.NewInt(101))
address2 common.Address = common.BigToAddress(big.NewInt(102))
address3 common.Address = common.BigToAddress(big.NewInt(103))
blockHash common.Hash = common.BigToHash(big.NewInt(9999))
emptyTxConfig statedb.TxConfig = statedb.NewEmptyTxConfig(blockHash)
)
type StateDBTestSuite struct {
suite.Suite
}
func (suite *StateDBTestSuite) TestAccounts() {
addr2 := common.BigToAddress(big.NewInt(2))
testTxConfig := statedb.NewTxConfig(
common.BigToHash(big.NewInt(10)), // tx hash
common.BigToHash(big.NewInt(11)), // block hash
1, // txIndex
1, // logSize
)
func (suite *StateDBTestSuite) TestAccount() {
key1 := common.BigToHash(big.NewInt(1))
value1 := common.BigToHash(big.NewInt(2))
key2 := common.BigToHash(big.NewInt(3))
value2 := common.BigToHash(big.NewInt(4))
testCases := []struct {
msg string
test func(*statedb.StateDB)
name string
malleate func(*statedb.StateDB)
}{
{
"success, empty account",
func(db *statedb.StateDB) {
suite.Require().Equal(true, db.Empty(addr2))
suite.Require().Equal(big.NewInt(0), db.GetBalance(addr2))
suite.Require().Equal([]byte(nil), db.GetCode(addr2))
suite.Require().Equal(uint64(0), db.GetNonce(addr2))
},
},
{
"success, GetBalance",
func(db *statedb.StateDB) {
db.AddBalance(addr2, big.NewInt(1))
suite.Require().Equal(big.NewInt(1), db.GetBalance(addr2))
},
},
{
"success, change balance",
func(db *statedb.StateDB) {
db.AddBalance(addr2, big.NewInt(2))
suite.Require().Equal(big.NewInt(2), db.GetBalance(addr2))
db.SubBalance(addr2, big.NewInt(1))
suite.Require().Equal(big.NewInt(1), db.GetBalance(addr2))
{"non-exist account", func(db *statedb.StateDB) {
suite.Require().Equal(false, db.Exist(address))
suite.Require().Equal(true, db.Empty(address))
suite.Require().Equal(big.NewInt(0), db.GetBalance(address))
suite.Require().Equal([]byte(nil), db.GetCode(address))
suite.Require().Equal(common.Hash{}, db.GetCodeHash(address))
suite.Require().Equal(uint64(0), db.GetNonce(address))
}},
{"empty account", func(db *statedb.StateDB) {
db.CreateAccount(address)
suite.Require().NoError(db.Commit())
keeper := db.Keeper().(*MockKeeper)
acct := keeper.accounts[address]
suite.Require().Equal(statedb.NewEmptyAccount(), &acct.account)
suite.Require().Empty(acct.states)
suite.Require().False(acct.account.IsContract())
db = statedb.New(sdk.Context{}, keeper, emptyTxConfig)
suite.Require().Equal(true, db.Exist(address))
suite.Require().Equal(true, db.Empty(address))
suite.Require().Equal(big.NewInt(0), db.GetBalance(address))
suite.Require().Equal([]byte(nil), db.GetCode(address))
suite.Require().Equal(common.BytesToHash(emptyCodeHash), db.GetCodeHash(address))
suite.Require().Equal(uint64(0), db.GetNonce(address))
}},
{"suicide", func(db *statedb.StateDB) {
// non-exist account.
suite.Require().False(db.Suicide(address))
suite.Require().False(db.HasSuicided(address))
// create a contract account
db.CreateAccount(address)
db.SetCode(address, []byte("hello world"))
db.AddBalance(address, big.NewInt(100))
db.SetState(address, key1, value1)
db.SetState(address, key2, value2)
suite.Require().NoError(db.Commit())
// suicide
db = statedb.New(sdk.Context{}, db.Keeper(), emptyTxConfig)
suite.Require().False(db.HasSuicided(address))
suite.Require().True(db.Suicide(address))
// check dirty state
suite.Require().True(db.HasSuicided(address))
// balance is cleared
suite.Require().Equal(big.NewInt(0), db.GetBalance(address))
// but code and state are still accessible in dirty state
suite.Require().Equal(value1, db.GetState(address, key1))
suite.Require().Equal([]byte("hello world"), db.GetCode(address))
suite.Require().NoError(db.Commit())
// create a clean StateDB, check the balance is committed
db = statedb.New(db.Context(), db.Keeper(), testTxConfig)
suite.Require().Equal(big.NewInt(1), db.GetBalance(addr2))
},
},
{
"success, SetState",
func(db *statedb.StateDB) {
key := common.BigToHash(big.NewInt(1))
value := common.BigToHash(big.NewInt(1))
// not accessible from StateDB anymore
db = statedb.New(sdk.Context{}, db.Keeper(), emptyTxConfig)
suite.Require().False(db.Exist(address))
suite.Require().Equal(common.Hash{}, db.GetState(addr2, key))
db.SetState(addr2, key, value)
suite.Require().Equal(value, db.GetState(addr2, key))
suite.Require().Equal(common.Hash{}, db.GetCommittedState(addr2, key))
},
},
{
"success, SetCode",
func(db *statedb.StateDB) {
code := []byte("hello world")
codeHash := crypto.Keccak256Hash(code)
db.SetCode(addr2, code)
suite.Require().Equal(code, db.GetCode(addr2))
suite.Require().Equal(codeHash, db.GetCodeHash(addr2))
// and cleared in keeper too
keeper := db.Keeper().(*MockKeeper)
suite.Require().Empty(keeper.accounts)
suite.Require().Empty(keeper.codes)
}},
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
tc.malleate(db)
})
}
}
suite.Require().NoError(db.Commit())
// create a clean StateDB, check the code is committed
db = statedb.New(db.Context(), db.Keeper(), testTxConfig)
suite.Require().Equal(code, db.GetCode(addr2))
suite.Require().Equal(codeHash, db.GetCodeHash(addr2))
},
},
{
"success, CreateAccount",
func(db *statedb.StateDB) {
func (suite *StateDBTestSuite) TestAccountOverride() {
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
// test balance carry over when overwritten
amount := big.NewInt(1)
code := []byte("hello world")
key := common.BigToHash(big.NewInt(1))
value := common.BigToHash(big.NewInt(1))
db.AddBalance(addr2, amount)
db.SetCode(addr2, code)
db.SetState(addr2, key, value)
// init an EOA account, account overriden only happens on EOA account.
db.AddBalance(address, amount)
db.SetNonce(address, 1)
rev := db.Snapshot()
// override
db.CreateAccount(address)
db.CreateAccount(addr2)
suite.Require().Equal(amount, db.GetBalance(addr2))
suite.Require().Equal([]byte(nil), db.GetCode(addr2))
suite.Require().Equal(common.Hash{}, db.GetState(addr2, key))
// check balance is not lost
suite.Require().Equal(amount, db.GetBalance(address))
// but nonce is reset
suite.Require().Equal(uint64(0), db.GetNonce(address))
}
db.RevertToSnapshot(rev)
suite.Require().Equal(amount, db.GetBalance(addr2))
suite.Require().Equal(code, db.GetCode(addr2))
suite.Require().Equal(value, db.GetState(addr2, key))
func (suite *StateDBTestSuite) TestDBError() {
testCases := []struct {
name string
malleate func(vm.StateDB)
}{
{"set account", func(db vm.StateDB) {
db.SetNonce(errAddress, 1)
}},
{"delete account", func(db vm.StateDB) {
db.SetNonce(errAddress, 1)
suite.Require().True(db.Suicide(errAddress))
}},
}
for _, tc := range testCases {
db := statedb.New(sdk.Context{}, NewMockKeeper(), emptyTxConfig)
tc.malleate(db)
suite.Require().Error(db.Commit())
}
}
db.CreateAccount(addr2)
func (suite *StateDBTestSuite) TestBalance() {
// NOTE: no need to test overflow/underflow, that is guaranteed by evm implementation.
testCases := []struct {
name string
malleate func(*statedb.StateDB)
expBalance *big.Int
}{
{"add balance", func(db *statedb.StateDB) {
db.AddBalance(address, big.NewInt(10))
}, big.NewInt(10)},
{"sub balance", func(db *statedb.StateDB) {
db.AddBalance(address, big.NewInt(10))
// get dirty balance
suite.Require().Equal(big.NewInt(10), db.GetBalance(address))
db.SubBalance(address, big.NewInt(2))
}, big.NewInt(8)},
{"add zero balance", func(db *statedb.StateDB) {
db.AddBalance(address, big.NewInt(0))
}, big.NewInt(0)},
{"sub zero balance", func(db *statedb.StateDB) {
db.SubBalance(address, big.NewInt(0))
}, big.NewInt(0)},
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
tc.malleate(db)
// check dirty state
suite.Require().Equal(tc.expBalance, db.GetBalance(address))
suite.Require().NoError(db.Commit())
db = statedb.New(db.Context(), db.Keeper(), testTxConfig)
suite.Require().Equal(amount, db.GetBalance(addr2))
suite.Require().Equal([]byte(nil), db.GetCode(addr2))
suite.Require().Equal(common.Hash{}, db.GetState(addr2, key))
},
},
// check committed balance too
suite.Require().Equal(tc.expBalance, keeper.accounts[address].account.Balance)
})
}
}
func (suite *StateDBTestSuite) TestState() {
key1 := common.BigToHash(big.NewInt(1))
value1 := common.BigToHash(big.NewInt(1))
testCases := []struct {
name string
malleate func(*statedb.StateDB)
expStates statedb.Storage
}{
{"empty state", func(db *statedb.StateDB) {
}, nil},
{"set empty value", func(db *statedb.StateDB) {
db.SetState(address, key1, common.Hash{})
}, statedb.Storage{}},
{"noop state change", func(db *statedb.StateDB) {
db.SetState(address, key1, value1)
db.SetState(address, key1, common.Hash{})
}, statedb.Storage{}},
{"set state", func(db *statedb.StateDB) {
// check empty initial state
suite.Require().Equal(common.Hash{}, db.GetState(address, key1))
suite.Require().Equal(common.Hash{}, db.GetCommittedState(address, key1))
// set state
db.SetState(address, key1, value1)
// query dirty state
suite.Require().Equal(value1, db.GetState(address, key1))
// check committed state is still not exist
suite.Require().Equal(common.Hash{}, db.GetCommittedState(address, key1))
// set same value again, should be noop
db.SetState(address, key1, value1)
suite.Require().Equal(value1, db.GetState(address, key1))
}, statedb.Storage{
key1: value1,
}},
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
tc.malleate(db)
suite.Require().NoError(db.Commit())
// check committed states in keeper
suite.Require().Equal(tc.expStates, keeper.accounts[address].states)
// check ForEachStorage
db = statedb.New(sdk.Context{}, keeper, emptyTxConfig)
collected := CollectContractStorage(db)
if len(tc.expStates) > 0 {
suite.Require().Equal(tc.expStates, collected)
} else {
suite.Require().Empty(collected)
}
})
}
}
func (suite *StateDBTestSuite) TestCode() {
code := []byte("hello world")
codeHash := crypto.Keccak256Hash(code)
testCases := []struct {
name string
malleate func(vm.StateDB)
expCode []byte
expCodeHash common.Hash
}{
{"non-exist account", func(vm.StateDB) {}, nil, common.Hash{}},
{"empty account", func(db vm.StateDB) {
db.CreateAccount(address)
}, nil, common.BytesToHash(emptyCodeHash)},
{"set code", func(db vm.StateDB) {
db.SetCode(address, code)
}, code, codeHash},
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
tc.malleate(db)
// check dirty state
suite.Require().Equal(tc.expCode, db.GetCode(address))
suite.Require().Equal(len(tc.expCode), db.GetCodeSize(address))
suite.Require().Equal(tc.expCodeHash, db.GetCodeHash(address))
suite.Require().NoError(db.Commit())
// check again
db = statedb.New(sdk.Context{}, keeper, emptyTxConfig)
suite.Require().Equal(tc.expCode, db.GetCode(address))
suite.Require().Equal(len(tc.expCode), db.GetCodeSize(address))
suite.Require().Equal(tc.expCodeHash, db.GetCodeHash(address))
})
}
}
func (suite *StateDBTestSuite) TestRevertSnapshot() {
v1 := common.BigToHash(big.NewInt(1))
v2 := common.BigToHash(big.NewInt(2))
v3 := common.BigToHash(big.NewInt(3))
testCases := []struct {
name string
malleate func(vm.StateDB)
}{
{"set state", func(db vm.StateDB) {
db.SetState(address, v1, v3)
}},
{"set nonce", func(db vm.StateDB) {
db.SetNonce(address, 10)
}},
{"change balance", func(db vm.StateDB) {
db.AddBalance(address, big.NewInt(10))
db.SubBalance(address, big.NewInt(5))
}},
{"override account", func(db vm.StateDB) {
db.CreateAccount(address)
}},
{"set code", func(db vm.StateDB) {
db.SetCode(address, []byte("hello world"))
}},
{"suicide", func(db vm.StateDB) {
db.SetState(address, v1, v2)
db.SetCode(address, []byte("hello world"))
suite.Require().True(db.Suicide(address))
}},
{"add log", func(db vm.StateDB) {
db.AddLog(&ethtypes.Log{
Address: address,
})
}},
{"add refund", func(db vm.StateDB) {
db.AddRefund(10)
db.SubRefund(5)
}},
{"access list", func(db vm.StateDB) {
db.AddAddressToAccessList(address)
db.AddSlotToAccessList(address, v1)
}},
}
for _, tc := range testCases {
suite.Run(tc.name, func() {
ctx := sdk.Context{}
keeper := NewMockKeeper()
{
"success, nested snapshot revert",
func(db *statedb.StateDB) {
// do some arbitrary changes to the storage
db := statedb.New(ctx, keeper, emptyTxConfig)
db.SetNonce(address, 1)
db.AddBalance(address, big.NewInt(100))
db.SetCode(address, []byte("hello world"))
db.SetState(address, v1, v2)
db.SetNonce(address2, 1)
suite.Require().NoError(db.Commit())
}
originalKeeper := keeper.Clone()
// run test
db := statedb.New(ctx, keeper, emptyTxConfig)
rev := db.Snapshot()
tc.malleate(db)
db.RevertToSnapshot(rev)
// check empty states after revert
suite.Require().Zero(db.GetRefund())
suite.Require().Empty(db.Logs())
suite.Require().NoError(db.Commit())
// check keeper should stay the same
suite.Require().Equal(originalKeeper, keeper)
})
}
}
func (suite *StateDBTestSuite) TestNestedSnapshot() {
key := common.BigToHash(big.NewInt(1))
value1 := common.BigToHash(big.NewInt(1))
value2 := common.BigToHash(big.NewInt(2))
db := statedb.New(sdk.Context{}, NewMockKeeper(), emptyTxConfig)
rev1 := db.Snapshot()
db.SetState(addr2, key, value1)
db.SetState(address, key, value1)
rev2 := db.Snapshot()
db.SetState(addr2, key, value2)
suite.Require().Equal(value2, db.GetState(addr2, key))
db.SetState(address, key, value2)
suite.Require().Equal(value2, db.GetState(address, key))
db.RevertToSnapshot(rev2)
suite.Require().Equal(value1, db.GetState(addr2, key))
suite.Require().Equal(value1, db.GetState(address, key))
db.RevertToSnapshot(rev1)
suite.Require().Equal(common.Hash{}, db.GetState(addr2, key))
},
},
{
"success, nonce",
func(db *statedb.StateDB) {
suite.Require().Equal(uint64(0), db.GetNonce(addr2))
db.SetNonce(addr2, 1)
suite.Require().Equal(uint64(1), db.GetNonce(addr2))
suite.Require().Equal(common.Hash{}, db.GetState(address, key))
}
suite.Require().NoError(db.Commit())
func (suite *StateDBTestSuite) TestInvalidSnapshotId() {
db := statedb.New(sdk.Context{}, NewMockKeeper(), emptyTxConfig)
suite.Require().Panics(func() {
db.RevertToSnapshot(1)
})
}
db = statedb.New(db.Context(), db.Keeper(), testTxConfig)
suite.Require().Equal(uint64(1), db.GetNonce(addr2))
},
},
{
"success, logs",
func(db *statedb.StateDB) {
func (suite *StateDBTestSuite) TestAccessList() {
value1 := common.BigToHash(big.NewInt(1))
value2 := common.BigToHash(big.NewInt(2))
testCases := []struct {
name string
malleate func(vm.StateDB)
}{
{"add address", func(db vm.StateDB) {
suite.Require().False(db.AddressInAccessList(address))
db.AddAddressToAccessList(address)
suite.Require().True(db.AddressInAccessList(address))
addrPresent, slotPresent := db.SlotInAccessList(address, value1)
suite.Require().True(addrPresent)
suite.Require().False(slotPresent)
// add again, should be no-op
db.AddAddressToAccessList(address)
suite.Require().True(db.AddressInAccessList(address))
}},
{"add slot", func(db vm.StateDB) {
addrPresent, slotPresent := db.SlotInAccessList(address, value1)
suite.Require().False(addrPresent)
suite.Require().False(slotPresent)
db.AddSlotToAccessList(address, value1)
addrPresent, slotPresent = db.SlotInAccessList(address, value1)
suite.Require().True(addrPresent)
suite.Require().True(slotPresent)
// add another slot
db.AddSlotToAccessList(address, value2)
addrPresent, slotPresent = db.SlotInAccessList(address, value2)
suite.Require().True(addrPresent)
suite.Require().True(slotPresent)
// add again, should be noop
db.AddSlotToAccessList(address, value2)
addrPresent, slotPresent = db.SlotInAccessList(address, value2)
suite.Require().True(addrPresent)
suite.Require().True(slotPresent)
}},
{"prepare access list", func(db vm.StateDB) {
al := ethtypes.AccessList{{
Address: address3,
StorageKeys: []common.Hash{value1},
}}
db.PrepareAccessList(address, &address2, vm.PrecompiledAddressesBerlin, al)
// check sender and dst
suite.Require().True(db.AddressInAccessList(address))
suite.Require().True(db.AddressInAccessList(address2))
// check precompiles
suite.Require().True(db.AddressInAccessList(common.BytesToAddress([]byte{1})))
// check AccessList
suite.Require().True(db.AddressInAccessList(address3))
addrPresent, slotPresent := db.SlotInAccessList(address3, value1)
suite.Require().True(addrPresent)
suite.Require().True(slotPresent)
addrPresent, slotPresent = db.SlotInAccessList(address3, value2)
suite.Require().True(addrPresent)
suite.Require().False(slotPresent)
}},
}
for _, tc := range testCases {
db := statedb.New(sdk.Context{}, NewMockKeeper(), emptyTxConfig)
tc.malleate(db)
}
}
func (suite *StateDBTestSuite) TestLog() {
txHash := common.BytesToHash([]byte("tx"))
// use a non-default tx config
txConfig := statedb.NewTxConfig(
blockHash,
txHash,
1, 1,
)
db := statedb.New(sdk.Context{}, NewMockKeeper(), txConfig)
data := []byte("hello world")
db.AddLog(&ethtypes.Log{
Address: addr2,
Address: address,
Topics: []common.Hash{},
Data: data,
BlockNumber: 1,
})
suite.Require().Equal(1, len(db.Logs()))
expecedLog := &ethtypes.Log{
Address: addr2,
Address: address,
Topics: []common.Hash{},
Data: data,
BlockNumber: 1,
BlockHash: common.BigToHash(big.NewInt(10)),
TxHash: common.BigToHash(big.NewInt(11)),
BlockHash: blockHash,
TxHash: txHash,
TxIndex: 1,
Index: 1,
}
suite.Require().Equal(expecedLog, db.Logs()[0])
rev := db.Snapshot()
db.AddLog(&ethtypes.Log{
Address: addr2,
Address: address,
Topics: []common.Hash{},
Data: data,
BlockNumber: 1,
})
suite.Require().Equal(2, len(db.Logs()))
suite.Require().Equal(uint(2), db.Logs()[1].Index)
expecedLog.Index++
suite.Require().Equal(expecedLog, db.Logs()[1])
}
db.RevertToSnapshot(rev)
suite.Require().Equal(1, len(db.Logs()))
},
},
{
"success, refund",
func(db *statedb.StateDB) {
func (suite *StateDBTestSuite) TestRefund() {
testCases := []struct {
name string
malleate func(vm.StateDB)
expRefund uint64
expPanic bool
}{
{"add refund", func(db vm.StateDB) {
db.AddRefund(uint64(10))
}, 10, false},
{"sub refund", func(db vm.StateDB) {
db.AddRefund(uint64(10))
suite.Require().Equal(uint64(10), db.GetRefund())
rev := db.Snapshot()
db.SubRefund(uint64(5))
suite.Require().Equal(uint64(5), db.GetRefund())
db.RevertToSnapshot(rev)
suite.Require().Equal(uint64(10), db.GetRefund())
},
},
{
"success, empty",
func(db *statedb.StateDB) {
suite.Require().False(db.Exist(addr2))
suite.Require().True(db.Empty(addr2))
db.AddBalance(addr2, big.NewInt(1))
suite.Require().True(db.Exist(addr2))
suite.Require().False(db.Empty(addr2))
db.SubBalance(addr2, big.NewInt(1))
suite.Require().True(db.Exist(addr2))
suite.Require().True(db.Empty(addr2))
},
},
{
"success, suicide commit",
func(db *statedb.StateDB) {
code := []byte("hello world")
db.SetCode(addr2, code)
db.AddBalance(addr2, big.NewInt(1))
suite.Require().True(db.Exist(addr2))
suite.Require().False(db.Empty(addr2))
db.Suicide(addr2)
suite.Require().True(db.HasSuicided(addr2))
suite.Require().True(db.Exist(addr2))
suite.Require().Equal(new(big.Int), db.GetBalance(addr2))
suite.Require().NoError(db.Commit())
db = statedb.New(db.Context(), db.Keeper(), testTxConfig)
suite.Require().True(db.Empty(addr2))
},
},
{
"success, suicide revert",
func(db *statedb.StateDB) {
code := []byte("hello world")
db.SetCode(addr2, code)
db.AddBalance(addr2, big.NewInt(1))
rev := db.Snapshot()
db.Suicide(addr2)
suite.Require().True(db.HasSuicided(addr2))
db.RevertToSnapshot(rev)
suite.Require().False(db.HasSuicided(addr2))
suite.Require().Equal(code, db.GetCode(addr2))
suite.Require().Equal(big.NewInt(1), db.GetBalance(addr2))
},
},
// TODO access lisForEachStorage
// https://github.com/tharsis/ethermint/issues/876
}, 5, false},
{"negative refund counter", func(db vm.StateDB) {
db.AddRefund(uint64(5))
db.SubRefund(uint64(10))
}, 0, true},
}
for _, tc := range testCases {
suite.Run(tc.msg, func() {
db := statedb.New(
sdk.Context{},
NewMockKeeper(),
testTxConfig,
)
tc.test(db)
db := statedb.New(sdk.Context{}, NewMockKeeper(), emptyTxConfig)
if !tc.expPanic {
tc.malleate(db)
suite.Require().Equal(tc.expRefund, db.GetRefund())
} else {
suite.Require().Panics(func() {
tc.malleate(db)
})
}
}
}
func (suite *StateDBTestSuite) TestIterateStorage() {
key1 := common.BigToHash(big.NewInt(1))
value1 := common.BigToHash(big.NewInt(2))
key2 := common.BigToHash(big.NewInt(3))
value2 := common.BigToHash(big.NewInt(4))
keeper := NewMockKeeper()
db := statedb.New(sdk.Context{}, keeper, emptyTxConfig)
db.SetState(address, key1, value1)
db.SetState(address, key2, value2)
// ForEachStorage only iterate committed state
suite.Require().Empty(CollectContractStorage(db))
suite.Require().NoError(db.Commit())
storage := CollectContractStorage(db)
suite.Require().Equal(2, len(storage))
suite.Require().Equal(keeper.accounts[address].states, storage)
// break early iteration
storage = make(statedb.Storage)
db.ForEachStorage(address, func(k, v common.Hash) bool {
storage[k] = v
// return false to break early
return false
})
suite.Require().Equal(1, len(storage))
}
func CollectContractStorage(db vm.StateDB) statedb.Storage {
storage := make(statedb.Storage)
db.ForEachStorage(address, func(k, v common.Hash) bool {
storage[k] = v
return true
})
return storage
}
func TestStateDBTestSuite(t *testing.T) {