rm confusing comments
Some checks failed
Build / cleanup-runs (pull_request) Failing after 2s
Deploy Contract / cleanup-runs (pull_request) Failing after 3s
Dependency Review / dependency-review (pull_request) Successful in 1m1s
Deploy Contract / deploy (pull_request) Failing after 56s
Pull Request Labeler / triage (pull_request) Failing after 3s
Build / build (pull_request) Successful in 1m11s
Lint / Run flake8 on python integration tests (pull_request) Failing after 32s
Protobuf / lint (pull_request) Failing after 28s
Lint / Run golangci-lint (pull_request) Successful in 43s
Semgrep / Scan (pull_request) Failing after 11s
Tests / cleanup-runs (pull_request) Failing after 2s
Protobuf / break-check (pull_request) Failing after 20s
Run Gosec / Gosec (pull_request) Successful in 25s
Tests / test-importer (pull_request) Successful in 1m9s
Tests / test-unit-cover (pull_request) Successful in 1m10s
Tests / test-rpc (pull_request) Successful in 1m12s
CodeQL / Analyze (go) (pull_request) Successful in 3m41s
Tests / sdk_tests (pull_request) Failing after 1m40s

This commit is contained in:
Roy Crihfield 2023-11-26 18:39:51 +08:00
parent 9bb3dc4216
commit e173f0a321
2 changed files with 1 additions and 6 deletions

View File

@ -300,8 +300,7 @@ func (k Keeper) processRecord(ctx sdk.Context, record *types.ReadableRecord, isR
} }
k.PutRecord(ctx, recordObj) k.PutRecord(ctx, recordObj)
// TODO process type here // TODO look up/validate record type here
// recordType, ok := record.Attributes["type"].(string)
if err := k.processAttributes(ctx, record.Attributes, record.ID, ""); err != nil { if err := k.processAttributes(ctx, record.Attributes, record.ID, ""); err != nil {
return err return err

View File

@ -13,10 +13,6 @@ const (
AuthorityUnderAuction = "auction" AuthorityUnderAuction = "auction"
) )
// TODO if schema records are to be more permissive than allowing a map of fields, this type will
// become specific to content records. schema records will either occupy a new message or have new
// more general purpose helper types.
// ReadablePayload represents a signed record payload that can be serialized from/to YAML. // ReadablePayload represents a signed record payload that can be serialized from/to YAML.
type ReadablePayload struct { type ReadablePayload struct {
Record map[string]interface{} `json:"record"` Record map[string]interface{} `json:"record"`