From b2155e709daab67b4d4c0047f06eafe0968c697e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Federico=20Kunze=20K=C3=BCllmer?= <31522760+fedekunze@users.noreply.github.com> Date: Thu, 10 Nov 2022 11:00:25 +0100 Subject: [PATCH] fix(rpc): decode `finalized` block number (#1442) * fix(rpc): decode 'finalized' block number * changelog Co-authored-by: Freddy Caceres --- CHANGELOG.md | 1 + rpc/types/block.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dec0b54f..7e4c2921 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -72,6 +72,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes +* (rpc) [#1442](https://github.com/evmos/ethermint/pull/1442) Fix decoding of `finalized` block number. * (rpc) [#1179](https://github.com/evmos/ethermint/pull/1179) Fix gas used in traceTransaction response. * (rpc) [#1284](https://github.com/evmos/ethermint/pull/1284) Fix internal trace response upon incomplete `eth_sendTransaction` call. * (rpc) [#1340](https://github.com/evmos/ethermint/pull/1340) Fix error response when `eth_estimateGas` height provided is not found. diff --git a/rpc/types/block.go b/rpc/types/block.go index 4296ed68..8918e77d 100644 --- a/rpc/types/block.go +++ b/rpc/types/block.go @@ -159,7 +159,7 @@ func (bnh *BlockNumberOrHash) decodeFromString(input string) error { case BlockParamEarliest: bn := EthEarliestBlockNumber bnh.BlockNumber = &bn - case BlockParamLatest: + case BlockParamLatest, BlockParamFinalized: bn := EthLatestBlockNumber bnh.BlockNumber = &bn case BlockParamPending: