cerc-io/laconicd-deprecated
19
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Update ante handler eth tx handler docs

Browse Source
This commit is contained in:
Aleksandr Bezobchuk 2018-10-03 12:43:00 -04:00
parent e4c1e28f30
commit ae64fb6e33
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
handlers/ante.go
View File

@ -73,9 +73,6 @@ func AnteHandler(accMapper auth.AccountMapper, _ auth.FeeCollectionKeeper) sdk.A
// handleEthTx implements an ante handler for an Ethereum transaction. It // handleEthTx implements an ante handler for an Ethereum transaction. It
// validates the signature and if valid returns an OK result. // validates the signature and if valid returns an OK result.
//
// TODO: Do we need to do any further validation or account manipulation
// (e.g. increment nonce)?
func handleEthTx(sdkCtx sdk.Context, tx sdk.Tx, accMapper auth.AccountMapper) (sdk.Context, sdk.Result, bool) { func handleEthTx(sdkCtx sdk.Context, tx sdk.Tx, accMapper auth.AccountMapper) (sdk.Context, sdk.Result, bool) {
ethTx, ok := tx.(types.Transaction) ethTx, ok := tx.(types.Transaction)
if !ok { if !ok {
@ -85,7 +82,6 @@ func handleEthTx(sdkCtx sdk.Context, tx sdk.Tx, accMapper auth.AccountMapper) (s
// the SDK chainID is a string representation of integer // the SDK chainID is a string representation of integer
chainID, ok := new(big.Int).SetString(sdkCtx.ChainID(), 10) chainID, ok := new(big.Int).SetString(sdkCtx.ChainID(), 10)
if !ok { if !ok {
// TODO: ErrInternal may not be correct error to throw here?
return sdkCtx, sdk.ErrInternal(fmt.Sprintf("invalid chainID: %s", sdkCtx.ChainID())).Result(), true return sdkCtx, sdk.ErrInternal(fmt.Sprintf("invalid chainID: %s", sdkCtx.ChainID())).Result(), true
} }
@ -104,10 +100,16 @@ func handleEthTx(sdkCtx sdk.Context, tx sdk.Tx, accMapper auth.AccountMapper) (s
return sdkCtx, sdk.ErrInvalidSequence(fmt.Sprintf("invalid account nonce; expected: %d", seq)).Result(), true return sdkCtx, sdk.ErrInvalidSequence(fmt.Sprintf("invalid account nonce; expected: %d", seq)).Result(), true
} }
err = acc.SetSequence(seq + 1) // TODO: The EVM will handle incrementing the nonce (sequence number)
if err != nil { //
return sdkCtx, sdk.ErrInternal(err.Error()).Result(), true // TODO: Investigate gas consumption models as the EVM instruction set has its
} // own and we should probably not charge for additional gas where we don't have
// to.
//
// err = acc.SetSequence(seq + 1)
// if err != nil {
// return sdkCtx, sdk.ErrInternal(err.Error()).Result(), true
// }
accMapper.SetAccount(sdkCtx, acc) accMapper.SetAccount(sdkCtx, acc)
return sdkCtx, sdk.Result{GasWanted: int64(ethTx.Data().GasLimit)}, false return sdkCtx, sdk.Result{GasWanted: int64(ethTx.Data().GasLimit)}, false