cerc-io/laconicd-deprecated
19
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

x/evm/types: properly split in 32 chunks trace.Memory (#838)

Browse Source 
This change fixes an insidious bug that unfortunately
tried to split values in multiples of 32, but unfortunately
due to the loop conditions, if the length of trace.Memory
was less than 32, nothing would be added; if the value wasn't
a multiple of 32, the ends wouldn't be added in.

Fixes #837
This commit is contained in:
Emmanuel T Odeke 2021-12-14 18:29:49 -08:00 committed by GitHub
parent ccc6f5b53d
commit 66292080e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -51,6 +51,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
### Bug Fixes ### Bug Fixes
* (rpc) [tharsis#831](https://github.com/tharsis/ethermint/pull/831) Fix BaseFee value when height is specified. * (rpc) [tharsis#831](https://github.com/tharsis/ethermint/pull/831) Fix BaseFee value when height is specified.
* (evm) [tharsis#838](https://github.com/tharsis/ethermint/pull/838) Fix splitting of trace.Memory into 32 chunks.
## [v0.9.0] - 2021-12-01 ## [v0.9.0] - 2021-12-01

9
x/evm/types/tracer.go
View File

@ -101,8 +101,13 @@ func FormatLogs(logs []vm.StructLog) []StructLogRes {
if trace.Memory != nil { if trace.Memory != nil {
memory := make([]string, 0, (len(trace.Memory)+31)/32) memory := make([]string, 0, (len(trace.Memory)+31)/32)
for i := 0; i+32 <= len(trace.Memory); i += 32 { for i, n := 0, len(trace.Memory); i < n; {
memory = append(memory, fmt.Sprintf("%x", trace.Memory[i:i+32])) end := i + 32
if end >= n {
end = n
}
memory = append(memory, fmt.Sprintf("%x", trace.Memory[i:end]))
i = end
} }
formatted[index].Memory = &memory formatted[index].Memory = &memory
} }