cerc-io/laconicd-deprecated
19
0
Fork 1
Code Issues 21 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

evm: update empty hash check for storage state (#1016)

Browse Source
This commit is contained in:
Federico Kunze Küllmer 2022-03-29 14:57:52 +02:00 committed by GitHub
parent 70d52948da
commit 285c7c47d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
x/evm/types/storage.go
View File

@ -2,11 +2,10 @@ package types
import ( import (
"fmt" "fmt"
"strings"
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors" sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
"github.com/ethereum/go-ethereum/common" "github.com/ethereum/go-ethereum/common"
"github.com/tharsis/ethermint/types"
) )
// Storage represents the account Storage map as a slice of single key value // Storage represents the account Storage map as a slice of single key value
@ -49,11 +48,12 @@ func (s Storage) Copy() Storage {
} }
// Validate performs a basic validation of the State fields. // Validate performs a basic validation of the State fields.
// NOTE: state value can be empty
func (s State) Validate() error { func (s State) Validate() error {
if types.IsEmptyHash(s.Key) { if strings.TrimSpace(s.Key) == "" {
return sdkerrors.Wrap(ErrInvalidState, "state key hash cannot be empty") return sdkerrors.Wrap(ErrInvalidState, "state key hash cannot be blank")
} }
// NOTE: state value can be empty
return nil return nil
} }

2
x/evm/types/storage_test.go
View File

@ -23,7 +23,7 @@ func TestStorageValidate(t *testing.T) {
{ {
"empty storage key bytes", "empty storage key bytes",
Storage{ Storage{
{Key: common.Hash{}.String()}, {Key: ""},
}, },
false, false,
}, },