laconicd-deprecated/.github/PULL_REQUEST_TEMPLATE.md

35 lines
1.6 KiB
Markdown
Raw Normal View History

2018-08-01 12:35:42 +00:00
<!-- < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < < ☺
2018-07-09 19:47:49 +00:00
v ✰ Thanks for creating a PR! ✰
2018-08-01 12:35:42 +00:00
v Before smashing the submit button please review the checkboxes.
2018-07-09 19:47:49 +00:00
v If a checkbox is n/a - please still include it but + a little note why
2018-08-01 12:35:42 +00:00
☺ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -->
2018-07-09 19:47:49 +00:00
Closes: #XXX
2018-09-06 18:54:17 +00:00
## Description
<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review.
-->
______
For contributor use:
- [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [ ] Wrote unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [ ] Re-reviewed `Files changed` in the Github PR explorer
2018-09-06 18:54:17 +00:00
______
For admin use:
- [ ] Added appropriate labels to PR (ex. `WIP`, `R4R`, `docs`, etc)
- [ ] Reviewers assigned
- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))