cerc-io/laconic-wallet-web
16
0
Fork 2
Code Issues 1 Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Style with Laconic colors and branding #15

Merged
zramsay merged 27 commits from style/laconic-colors into main 2024-08-11 21:05:11 +00:00
Conversation 0 Commits 27 Files Changed 29 +1504 -985
cfbender commented 2024-08-09 19:50:17 +00:00
Member
Copy Link

implements more MUI components, and updates colors/styles to match designs

implements more MUI components, and updates colors/styles to match designs
cfbender added 17 commits 2024-08-09 19:50:18 +00:00
cfbender force-pushed style/laconic-colors from 7f44fc1cf0 to ec3617ad42 2024-08-09 20:07:03 +00:00 Compare
cfbender added 1 commit 2024-08-09 20:10:26 +00:00
cfbender added 1 commit 2024-08-09 20:13:35 +00:00
munkeyxis added 1 commit 2024-08-09 21:17:59 +00:00
cfbender added 1 commit 2024-08-09 21:33:19 +00:00
munkeyxis added 2 commits 2024-08-09 21:34:16 +00:00
zramsay requested changes 2024-08-10 20:00:17 +00:00
zramsay left a comment
Member
Copy Link

see all the comments

see all the comments
src/components/MnemonicDialog.tsx Outdated
@ -21,2 +32,3 @@
Make sure to note it down.
</Typography>
<Typography variant="h6" component="div" style={{ ...styles.dialogWarning }}>
<Typography component="div" style={{ ...styles.mnomonicDialogWarning }}>
zramsay commented 2024-08-10 19:20:51 +00:00
Member
Copy Link

typo?

typo?
cfbender marked this conversation as resolved
src/screens/AddNetwork.tsx
@ -381,3 +305,3 @@
<Controller
control={control}
name="gasPrice"
name="coinType"
zramsay commented 2024-08-10 19:22:29 +00:00
Member
Copy Link

hmm

hmm
zramsay commented 2024-08-10 20:01:08 +00:00
Member
Copy Link

should probably remain the same

should probably remain the same
cfbender commented 2024-08-10 21:46:20 +00:00
Author
Member
Copy Link

this is just the way the diff shows it due to lines being added above. I didn't change these fields, I just wrapped them with Grid components. if you look at the diff with whitepsace changes hidden it should be a little clearer

this is just the way the diff shows it due to lines being added above. I didn't change these fields, I just wrapped them with `Grid` components. if you look at the diff with whitepsace changes hidden it should be a little clearer
zramsay marked this conversation as resolved
src/screens/HomeScreen.tsx Outdated
@ -178,4 +174,0 @@
isWalletCreating={isWalletCreating}
createWalletHandler={createWalletHandler}
/>
{ IS_IMPORT_WALLET_ENABLED && <View style={styles.createWalletContainer}>
zramsay commented 2024-08-10 19:26:00 +00:00
Member
Copy Link

where did this env go?

where did this env go?
cfbender marked this conversation as resolved
src/screens/HomeScreen.tsx Outdated
@ -45,3 +45,3 @@
// eslint-disable-next-line react/no-unstable-nested-components
headerRight: () => (
<Button onPress={() => navigation.navigate('WalletConnect')}>
<Button onClick={() => navigation.navigate("WalletConnect")}>
zramsay commented 2024-08-10 19:25:10 +00:00
Member
Copy Link

could this somehow hide it?

could this somehow hide it?
cfbender marked this conversation as resolved
cfbender added 1 commit 2024-08-10 20:10:41 +00:00
cfbender added 1 commit 2024-08-10 21:50:13 +00:00
cfbender requested review from zramsay 2024-08-10 21:51:31 +00:00
zramsay added 1 commit 2024-08-10 22:59:09 +00:00
zramsay added 1 commit 2024-08-10 23:10:51 +00:00
zramsay added 1 commit 2024-08-11 21:01:09 +00:00
zramsay merged commit e5c5d13c77 into main 2024-08-11 21:05:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
zramsay
Labels
Clear labels
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-wallet-web#15
No description provided.
Delete Branch "style/laconic-colors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?