fix: tests failing against updated laconicd #5

i-norden · 2022-11-01T10:11:53Z

0xmuralik commented

2022-11-01 10:11:53 +00:00

(Migrated from github.com)

Closes: https://github.com/cerc-io/laconicd/issues/45

i-norden reviewed 2022-11-01 10:11:53 +00:00

dboreham commented

2022-11-01 12:34:19 +00:00

Many tests still fail for me, so I think there must be some other difference between your setup and mine.
Which version of node.js are you using? I had varying results between 16, 17, 18, although none resulted in 100% pass.

Many tests still fail for me, so I think there must be some other difference between your setup and mine. Which version of node.js are you using? I had varying results between 16, 17, 18, although none resulted in 100% pass.

0xmuralik commented

2022-11-02 04:58:26 +00:00

(Migrated from github.com)

Try with node 16. One test fails in utils. Apart from that everything else should pass.

dboreham commented

2022-11-04 12:04:56 +00:00

After re-testing with Node 16, 17, 18 -- these tests only work with Node 16. 4 extra tests fail using Node 17 and 18.

https://github.com/cerc-io/laconic-sdk/issues/6

After re-testing with Node 16, 17, 18 -- these tests only work with Node 16. 4 extra tests fail using Node 17 and 18. https://github.com/cerc-io/laconic-sdk/issues/6

dboreham approved these changes 2022-11-04 12:46:03 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-sdk#5