add support for remaining record content types #24

New Issue

i-norden · 2023-01-23T05:07:28Z

0xmuralik commented

2023-01-23 05:07:28 +00:00

(Migrated from github.com)

SIster of https://github.com/cerc-io/laconicd/issues/51

0xmuralik commented

2023-01-23 05:07:58 +00:00

(Migrated from github.com)

Blocked: https://github.com/cerc-io/laconic-sdk/issues/23

i-norden commented

2023-03-06 21:46:56 +00:00

I believe this was closed prematurely as was https://github.com/cerc-io/laconic-sdk/pull/27 because its sister issue is still pending https://github.com/cerc-io/laconicd/pull/79 and some of the changes there are still subject to change (which will require reflecting the changes back to here).

Also, since the unit tests were passing on https://github.com/cerc-io/laconic-sdk/pull/27 against the main branch of laconicd (missing the pending changes) this suggests to me that we are missing unit tests that cover the changes being made by these two PRs.

I believe this was closed prematurely as was https://github.com/cerc-io/laconic-sdk/pull/27 because its sister issue is still pending https://github.com/cerc-io/laconicd/pull/79 and some of the changes there are still subject to change (which will require reflecting the changes back to here). Also, since the unit tests were passing on https://github.com/cerc-io/laconic-sdk/pull/27 against the main branch of laconicd (missing the pending changes) this suggests to me that we are missing unit tests that cover the changes being made by these two PRs.

Sign in to join this conversation.

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/laconic-sdk#24