refactor tests to run independently

src/bond.test.ts

@@ -12,20 +12,10 @@ jest.setTimeout(90 * 1000);
 const bondTests = () => {
   let registry: Registry;
 
-  let watcher: any;
-
-  let version1: string;
-  let version2: string;
-
-  let bondId1: string;
-  let bondId2: string;
-
-  let bondOwner: string;
-
   const publishNewWatcherVersion = async (bondId: string) => {
-    watcher = await ensureUpdatedConfig(WATCHER_YML_PATH);
+    let watcher = await ensureUpdatedConfig(WATCHER_YML_PATH);
     await registry.setRecord({ privateKey, record: watcher.record, bondId }, privateKey, fee);
-    return watcher.record.version;
+    return watcher;
   };
 
   beforeAll(async () => {
@@ -33,93 +23,119 @@ const bondTests = () => {
   });
 
   test('Create bond.', async () => {
-    bondId1 = await registry.getNextBondId(privateKey);
+    let bondId = await registry.getNextBondId(privateKey);
+    expect(bondId).toBeDefined();
+    await registry.createBond({ denom: 'aphoton', amount: '1000000000' }, privateKey, fee);
+  });
+
+  describe('With bond created', () => {
+    let bond1: any
+
+    beforeAll(async () => {
+      let bondId1 = await registry.getNextBondId(privateKey);
       expect(bondId1).toBeDefined();
       await registry.createBond({ denom: 'aphoton', amount: '1000000000' }, privateKey, fee);
-  })
+
+      [bond1] = await registry.getBondsByIds([bondId1]);
+      expect(bond1).toBeDefined();
+      expect(bond1.id).toEqual(bondId1);
+    });
 
     test('Get bond by ID.', async () => {
-    const [bond] = await registry.getBondsByIds([bondId1]);
+      const [bond] = await registry.getBondsByIds([bond1.id]);
       expect(bond).toBeDefined();
-    expect(bond.id).toBe(bondId1);
+      expect(bond.id).toBe(bond1.id);
       expect(bond.balance).toHaveLength(1);
       expect(bond.balance[0]).toEqual({ type: 'aphoton', quantity: '1000000000' });
-    bondOwner = bond.owner;
     });
 
     test('Query bonds.', async () => {
       const bonds = await registry.queryBonds();
       expect(bonds).toBeDefined();
-    const bond = bonds.filter((bond: any) => bond.id === bondId1);
+      const bond = bonds.filter((bond: any) => bond.id === bond1.id);
       expect(bond).toBeDefined();
     });
 
     test('Query bonds by owner.', async () => {
-    const bonds = await registry.queryBonds({ owner: bondOwner });
+      const bonds = await registry.queryBonds({ owner: bond1.owner });
       expect(bonds).toBeDefined();
-    const bond = bonds.filter((bond: any) => bond.id === bondId1);
+      const bond = bonds.filter((bond: any) => bond.id === bond1.id);
       expect(bond).toBeDefined();
     });
 
     test('Refill bond.', async () => {
-    await registry.refillBond({ id: bondId1, denom: 'aphoton', amount: '500' }, privateKey, fee);
+      await registry.refillBond({ id: bond1.id, denom: 'aphoton', amount: '500' }, privateKey, fee);
 
-    const [bond] = await registry.getBondsByIds([bondId1]);
+      const [bond] = await registry.getBondsByIds([bond1.id]);
       expect(bond).toBeDefined();
-    expect(bond.id).toBe(bondId1);
+      expect(bond.id).toBe(bond1.id);
       expect(bond.balance).toHaveLength(1);
       expect(bond.balance[0]).toEqual({ type: 'aphoton', quantity: '1000000500' });
     });
 
     test('Withdraw bond.', async () => {
-    await registry.withdrawBond({ id: bondId1, denom: 'aphoton', amount: '500' }, privateKey, fee);
+      await registry.withdrawBond({ id: bond1.id, denom: 'aphoton', amount: '500' }, privateKey, fee);
 
-    const [bond] = await registry.getBondsByIds([bondId1]);
+      const [bond] = await registry.getBondsByIds([bond1.id]);
       expect(bond).toBeDefined();
-    expect(bond.id).toBe(bondId1);
+      expect(bond.id).toBe(bond1.id);
       expect(bond.balance).toHaveLength(1);
       expect(bond.balance[0]).toEqual({ type: 'aphoton', quantity: '1000000000' });
     });
 
     test('Cancel bond.', async () => {
-    await registry.cancelBond({ id: bondId1 }, privateKey, fee);
+      await registry.cancelBond({ id: bond1.id }, privateKey, fee);
 
-    const [bond] = await registry.getBondsByIds([bondId1]);
+      const [bond] = await registry.getBondsByIds([bond1.id]);
       expect(bond.id).toBe("");
       expect(bond.owner).toBe("");
       expect(bond.balance).toHaveLength(0);
     });
 
+  });
+
   test('Associate/Dissociate bond.', async () => {
+    let bondId1: string;
+
     bondId1 = await registry.getNextBondId(privateKey);
     expect(bondId1).toBeDefined();
     await registry.createBond({ denom: 'aphoton', amount: '1000000000' }, privateKey, fee);
 
     // Create a new record.
-    version1 = await publishNewWatcherVersion(bondId1);
+    let watcher = await publishNewWatcherVersion(bondId1);
-    let [record1] = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    let query = { type: watcher.record.type, url: watcher.record.url, version: watcher.record.version };
+    let [record1] = await registry.queryRecords(query, true);
     expect(record1.bondId).toBe(bondId1);
 
     // Dissociate record, query and confirm.
     await registry.dissociateBond({ recordId: record1.id }, privateKey, fee);
-    [record1] = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    [record1] = await registry.queryRecords(query, true);
     expect(record1.bondId).toBe('');
 
     // Associate record with bond, query and confirm.
     await registry.associateBond({ recordId: record1.id, bondId: bondId1 }, privateKey, fee);
-    [record1] = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    [record1] = await registry.queryRecords(query, true);
     expect(record1.bondId).toBe(bondId1);
   });
 
   test('Reassociate/Dissociate records.', async () => {
+    let bondId1: string;
+    let bondId2: string;
+
+    bondId1 = await registry.getNextBondId(privateKey);
+    expect(bondId1).toBeDefined();
+    await registry.createBond({ denom: 'aphoton', amount: '1000000000' }, privateKey, fee);
+
     // Create a new record version.
-    version2 = await publishNewWatcherVersion(bondId1);
+    let watcher = await publishNewWatcherVersion(bondId1);
+    let queryv1 = { type: watcher.record.type, url: watcher.record.url, version: watcher.record.version };
+    let queryv2 = { type: watcher.record.type, url: watcher.record.url, version: watcher.record.version };
 
     // Check version1, version2 as associated with bondId1.
     let records;
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    records = await registry.queryRecords(queryv1, true);
     expect(records[0].bondId).toBe(bondId1);
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version2 }, true);
+    records = await registry.queryRecords(queryv2, true);
     expect(records[0].bondId).toBe(bondId1);
 
     // Create another bond.
@@ -131,16 +147,16 @@ const bondTests = () => {
 
     // Reassociate records from bondId1 to bondId2, verify change.
     await registry.reassociateRecords({ oldBondId: bondId1, newBondId: bondId2 }, privateKey, fee);
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    records = await registry.queryRecords(queryv1, true);
     expect(records[0].bondId).toBe(bondId2);
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version2 }, true);
+    records = await registry.queryRecords(queryv2, true);
     expect(records[0].bondId).toBe(bondId2);
 
     // Dissociate all records from bond, verify change.
     await registry.dissociateRecords({ bondId: bondId2 }, privateKey, fee);
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version1 }, true);
+    records = await registry.queryRecords(queryv1, true);
     expect(records[0].bondId).toBe('');
-    records = await registry.queryRecords({ type: watcher.record.type, name: watcher.record.name, version: version2 }, true);
+    records = await registry.queryRecords(queryv2, true);
     expect(records[0].bondId).toBe('');
   });
 };

src/naming.test.ts

@@ -18,12 +18,6 @@ const namingTests = () => {
   let watcher: any;
   let watcherId: string;
 
-  let authorityName: string;
-  let otherAuthorityName: string;
-  let otherPrivateKey: string;
-
-  let crn: string;
-
   beforeAll(async () => {
     registry = new Registry(gqlEndpoint, restEndpoint, chainId);
 
@@ -46,11 +40,24 @@ const namingTests = () => {
     watcherId = result.data.id;
   });
 
+  describe('Authority tests', () => {
     test('Reserve authority.', async () => {
-    authorityName = `laconic-${Date.now()}`;
+      const authorityName = `laconic-${Date.now()}`;
+
       await registry.reserveAuthority({ name: authorityName }, privateKey, fee);
     });
 
+    describe('With authority reserved', () => {
+      let authorityName: string;
+      let crn: string;
+
+      beforeAll(async () => {
+        authorityName = `laconic-${Date.now()}`;
+        crn = `crn://${authorityName}/app/test`;
+
+        await registry.reserveAuthority({ name: authorityName }, privateKey, fee);
+      })
+
       test('Lookup authority.', async () => {
         const [record] = await registry.lookupAuthorities([authorityName]);
 
@@ -69,7 +76,8 @@ const namingTests = () => {
       });
 
       test('Reserve already reserved authority', async () => {
-    await expect(registry.reserveAuthority({ name: authorityName }, privateKey, fee)).rejects.toThrow('Name already reserved.');
+        await expect(registry.reserveAuthority({ name: authorityName }, privateKey, fee)).
+          rejects.toThrow('Name already reserved.');
       });
 
       test('Reserve sub-authority.', async () => {
@@ -105,23 +113,61 @@ const namingTests = () => {
       });
 
       test('Set name for unbonded authority', async () => {
-    crn = `crn://${authorityName}/app/test`;
         assert(watcherId)
-    await expect(registry.setName({ crn, cid: watcherId }, privateKey, fee)).rejects.toThrow('Authority bond not found.');
+        await expect(registry.setName({ crn, cid: watcherId }, privateKey, fee)).
+          rejects.toThrow('Authority bond not found.');
       });
 
       test('Set authority bond', async () => {
         await registry.setAuthorityBond({ name: authorityName, bondId }, privateKey, fee);
       });
+    });
+  });
+
+  describe('Naming tests', () => {
+    let authorityName: string;
+    let otherAuthorityName: string;
+    let otherPrivateKey: string;
+    let otherAccount: Account;
+
+    beforeAll(async () => {
+      authorityName = `laconic-${Date.now()}`;
+
+      await registry.reserveAuthority({ name: authorityName }, privateKey, fee);
+      await registry.setAuthorityBond({ name: authorityName, bondId }, privateKey, fee);
+
+      // Create another account.
+      const mnenonic = Account.generateMnemonic();
+      otherAccount = await Account.generateFromMnemonic(mnenonic);
+      await registry.sendCoins({ denom: 'aphoton', amount: '1000000000', destinationAddress: otherAccount.formattedCosmosAddress }, privateKey, fee);
+
+      otherAuthorityName = `other-${Date.now()}`;
+      otherPrivateKey = otherAccount.privateKey.toString('hex');
+    });
 
     test('Set name', async () => {
-    crn = `crn://${authorityName}/app/test`;
+      const crn = `crn://${authorityName}/app/test1`;
+
       await registry.setName({ crn, cid: watcherId }, privateKey, fee);
 
       // Query records should return it (some CRN points to it).
       const records = await registry.queryRecords({ type: 'WebsiteRegistrationRecord', version: watcher.record.version });
       expect(records).toBeDefined();
       expect(records).toHaveLength(1);
+
+      await registry.deleteName({ crn }, privateKey, fee);
+    });
+
+    describe('With name set', () => {
+      let crn: string;
+
+      beforeAll(async () => {
+        crn = `crn://${authorityName}/app/test2`;
+        await registry.setName({ crn, cid: watcherId }, privateKey, fee);
+      });
+
+      afterAll(async () => {
+        await registry.deleteName({ crn }, privateKey, fee);
       });
 
       test('Lookup name', async () => {
@@ -179,42 +225,6 @@ const namingTests = () => {
         expect(oldRecord.height).toBeDefined();
       });
 
-  test('Set name without reserving authority', async () => {
-    await expect(registry.setName({ crn: 'crn://not-reserved/app/test', cid: watcherId }, privateKey, fee))
-      .rejects.toThrow('Name authority not found.');
-  });
-
-  test('Set name for non-owned authority', async () => {
-    // Create another account.
-    const mnenonic = Account.generateMnemonic();
-    const otherAccount = await Account.generateFromMnemonic(mnenonic);
-    await registry.sendCoins({ denom: 'aphoton', amount: '1000000000', destinationAddress: otherAccount.formattedCosmosAddress }, privateKey, fee);
-
-    // Other account reserves an authority.
-    otherAuthorityName = `other-${Date.now()}`;
-    otherPrivateKey = otherAccount.privateKey.toString('hex');
-    await registry.reserveAuthority({ name: otherAuthorityName }, otherPrivateKey, fee);
-
-    // Try setting name under other authority.
-    await expect(registry.setName({ crn: `crn://${otherAuthorityName}/app/test`, cid: watcherId }, privateKey, fee)).rejects.toThrow('Access denied.');
-  });
-
-  test('Lookup non existing name', async () => {
-    const records = await registry.lookupNames(['crn://not-reserved/app/test']);
-    expect(records).toBeDefined();
-    expect(records).toHaveLength(1);
-    const [record] = records;
-    expect(record).toBeNull();
-  });
-
-  test('Resolve non existing name', async () => {
-    const records = await registry.resolveNames(['crn://not-reserved/app/test']);
-    expect(records).toBeDefined();
-    expect(records).toHaveLength(1);
-    const [record] = records;
-    expect(record).toBeNull();
-  });
-
       test('Delete name', async () => {
         await registry.deleteName({ crn }, privateKey, fee);
 
@@ -241,6 +251,7 @@ const namingTests = () => {
 
       test('Delete already deleted name', async () => {
         await registry.deleteName({ crn }, privateKey, fee);
+        await registry.deleteName({ crn }, privateKey, fee);
 
         const records = await registry.lookupNames([crn], true);
         expect(records).toBeDefined();
@@ -252,6 +263,22 @@ const namingTests = () => {
         expect(latest.id).toBe('');
         expect(latest.height).toBeDefined();
       });
+    });
+
+    test('Set name without reserving authority', async () => {
+      await expect(registry.setName({ crn: 'crn://not-reserved/app/test', cid: watcherId }, privateKey, fee))
+        .rejects.toThrow('Name authority not found.');
+    });
+
+    test('Set name for non-owned authority', async () => {
+      await registry.sendCoins({ denom: 'aphoton', amount: '1000000000', destinationAddress: otherAccount.formattedCosmosAddress }, privateKey, fee);
+
+      // Other account reserves an authority.
+      await registry.reserveAuthority({ name: otherAuthorityName }, otherPrivateKey, fee);
+
+      // Try setting name under other authority.
+      await expect(registry.setName({ crn: `crn://${otherAuthorityName}/app/test`, cid: watcherId }, privateKey, fee)).rejects.toThrow('Access denied.');
+    });
 
     test('Delete name for non-owned authority.', async () => {
       const otherBondId = await registry.getNextBondId(otherPrivateKey);
@@ -262,6 +289,23 @@ const namingTests = () => {
       // Try deleting name under other authority.
       await expect(registry.deleteName({ crn: `crn://${otherAuthorityName}/app/test` }, privateKey, fee)).rejects.toThrow('Access denied.');
     });
+
+    test('Lookup non existing name', async () => {
+      const records = await registry.lookupNames(['crn://not-reserved/app/test']);
+      expect(records).toBeDefined();
+      expect(records).toHaveLength(1);
+      const [record] = records;
+      expect(record).toBeNull();
+    });
+
+    test('Resolve non existing name', async () => {
+      const records = await registry.resolveNames(['crn://not-reserved/app/test']);
+      expect(records).toBeDefined();
+      expect(records).toHaveLength(1);
+      const [record] = records;
+      expect(record).toBeNull();
+    });
+  });
 };
 
 if (process.env.TEST_AUCTIONS_ENABLED) {