Update RPC api and backend to support the EIP-2930 and EIP-1559. #83

i-norden · 2021-07-27T12:24:18Z

arijitAD commented

2021-07-27 12:24:18 +00:00

(Migrated from github.com)

Fixes #78

ashwinphatak (Migrated from github.com) reviewed 2021-07-27 12:24:18 +00:00

i-norden reviewed 2021-07-28 06:30:04 +00:00

i-norden left a comment

Looks great! I think we should update/add some integration tests to test the RPC output of the new types vs the output of standard geth json-rpc.

Also related is https://github.com/vulcanize/ipld-eth-indexer/pull/86#pullrequestreview-716611486. Ideally we'd update to import from vulcanize geth rather than updating the ipld-eth-indexer dep. But this can be handled as the separate issue in a different PR if you'd prefer.

Looks great! I think we should update/add some integration tests to test the RPC output of the new types vs the output of standard geth json-rpc. Also related is https://github.com/vulcanize/ipld-eth-indexer/pull/86#pullrequestreview-716611486. Ideally we'd update to import from vulcanize geth rather than updating the ipld-eth-indexer dep. But this can be handled as [the separate issue](https://github.com/vulcanize/ipld-eth-indexer/issues/84) in a different PR if you'd prefer.

db/migrations/00014_create_stored_functions.sql

i-norden commented

2021-07-28 06:18:50 +00:00

If this needs changed the comment for the function should be updated too