getLogs API changes to return txHash, make contract arg optional. #81

i-norden · 2021-07-12T11:31:02Z

ashwinphatak commented

2021-07-12 11:31:02 +00:00

(Migrated from github.com)

Part of https://github.com/vulcanize/watcher-ts/issues/116

i-norden approved these changes 2021-07-22 16:59:49 +00:00

i-norden left a comment

LGTM!

pkg/eth/ipld_retriever.go

i-norden commented

2021-07-22 16:59:42 +00:00

We could do HexToHash here and return a slice of common.Hash instead so don't need to do it in different places above this level, but that's super nitpicky and maybe there is a reason to leave it as a hex string at this level.

We could do HexToHash here and return a slice of `common.Hash` instead so don't need to do it in different places above this level, but that's super nitpicky and maybe there is a reason to leave it as a hex string at this level.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#81