Docker compose and CI #6

Merged
ramilexe merged 4 commits from docker into master 2020-09-09 20:12:36 +00:00
ramilexe commented 2020-09-09 15:50:51 +00:00 (Migrated from github.com)

Integration with eth-indexer, dapptools, postgraphile

Integration with eth-indexer, dapptools, postgraphile
roysc reviewed 2020-09-09 15:50:51 +00:00
i-norden approved these changes 2020-09-09 18:42:23 +00:00
i-norden left a comment
Member

LGTM! I can't find anything to fix, I commented one minor optional cleanup.

LGTM! I can't find anything to fix, I commented one minor optional cleanup.
@ -0,0 +9,4 @@
echo "Running database migrations"
./goose -dir migrations/vulcanizedb postgres "$VDB_PG_CONNECT" up
rv=$?
Member

I think we should get rid of this set +e and the set -e on line 5, and get rid of the commented out stuff in-between them.

I think we should get rid of this `set +e` and the `set -e` on line 5, and get rid of the commented out stuff in-between them.
@ -62,3 +62,3 @@
wsPath := viper.GetString("watcher.wsPath")
wsPath := viper.GetString("server.wsPath")
if wsPath == "" {
Member

Nice catch, thanks for fixing these!

Nice catch, thanks for fixing these!
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#6
No description provided.