cerc-io/ipld-eth-server
12
0
Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

[WIP] merge proxy command to serve command #50

Merged
ramilexe merged 39 commits from endpoints into master 2021-06-18 14:35:56 +00:00
Conversation 4 Commits 39 Files Changed 39
+29471 -440
ramilexe commented 2021-04-14 15:54:19 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
i-norden approved these changes 2021-04-19 12:38:13 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

The table with all the params and their env variables is a great addition. Only one small reformatting fix I caught, and we should also bump the version. Otherwise LGTM!

The table with all the params and their env variables is a great addition. Only one small reformatting fix I caught, and we should also bump the version. Otherwise LGTM!
README.md
@@ -121,6 +121,32 @@ The currently supported standard endpoints are:
TODO: Add the rest of the standard endpoints and unique endpoints (e.g. getSlice)
i-norden commented 2021-04-19 12:33:46 +00:00
Member
Copy Link
Copy Source

Very nice table, I think this helps a lot

Very nice table, I think this helps a lot
cmd/serve.go
i-norden commented 2021-04-19 12:34:35 +00:00
Member
Copy Link
Copy Source

Really minor but can we move this external dep out of the builtins

Really minor but can we move this external dep out of the builtins
i-norden commented 2021-04-19 14:46:35 +00:00
Member
Copy Link
Copy Source

Actually we can probably wait to bump version til all the upcoming changes are in

Actually we can probably wait to bump version til all the upcoming changes are in
arijitAD (Migrated from github.com) reviewed 2021-06-18 11:44:08 +00:00
cmd/serve.go
arijitAD (Migrated from github.com) commented 2021-06-18 11:44:07 +00:00
Copy Link
Copy Source

Done

Done
i-norden approved these changes 2021-06-18 14:34:15 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

I think this LGTM. It's a bit hard to review since all the changes from the integration test branch are here now. In the future we should rebase ontop of master instead of merging master back into the working branch.

I think this LGTM. It's a bit hard to review since all the changes from the integration test branch are here now. In the future we should rebase ontop of master instead of merging master back into the working branch.
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
arijitAD
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#50