rlp.EncodeToBytes => tx.MarshalBinary #246
No reviewers
Labels
No Label
bug
critical
documentation
duplicate
enhancement
Epic
good first issue
help wanted
Integration tests
invalid
question
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/ipld-eth-server#246
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "ian_bug_fix"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
For #245
While Thomas was testing geth vs ipld-eth-server output a discrepancy was identified with the "eth_getRawTransaction*" endpoints:
I suspect this is the issue, if it isn't- it is still an issue.
rlp.EncodeToBytes
was also being used for the expected results we compare to in the unit and integration tests, so the results matched and the issue was not detected there.Why did Ian write this patch instead of Thomas?
When I found the bug this afternoon, I discussed it with Ian, and he had an idea on the fix before I had looked in to the cause.
Incidentally, this does look like a fix:
From: https://git.vdb.to/cerc-io/system-tests