Test improvements #244

Open
opened 2023-06-12 13:01:13 +00:00 by i-norden · 0 comments
Member
  • The integration tests that compare geth results to results returned by ipld-eth-server should compare the "raw" JSON returned from the endpoints, rather than first unpacking this JSON into Go types. This is because the Go types sometimes only represent a subset of the data returned in the JSON payload, see comments on.
  • API unit tests should test under different chainconfig (tx signer) conditions,
  • Tests should cover all tx types: https://github.com/cerc-io/ipld-eth-server/issues/243
  • getLogs tests should cover more filter conditions, including a block range test

See comments on https://github.com/cerc-io/ipld-eth-server/pull/242

* The integration tests that compare geth results to results returned by ipld-eth-server should compare the "raw" JSON returned from the endpoints, rather than first unpacking this JSON into Go types. This is because the Go types sometimes only represent a subset of the data returned in the JSON payload, see comments on. * API unit tests should test under different chainconfig (tx signer) conditions, * Tests should cover all tx types: https://github.com/cerc-io/ipld-eth-server/issues/243 * getLogs tests should cover more filter conditions, including a block range test See comments on https://github.com/cerc-io/ipld-eth-server/pull/242
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#244
No description provided.