cerc-io/ipld-eth-server
12
0 Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

Fix for getTransactionReceipt returning empty 'from' address. #242

Merged
telackey merged 3 commits from telackey/receiptfix into v5 2023-06-12 16:37:46 +00:00
Conversation 3 Commits 3 Files Changed 3
+11 -11
telackey commented 2023-06-09 23:52:46 +00:00
Contributor
Copy link
Copy source

Fixes a bug where the wrong signer is used for getTransactionReceipt, leading to a null 'from' value, and unifies the code used to obtain a Signer for a tx.

Fixes a bug where the wrong signer is used for getTransactionReceipt, leading to a null 'from' value, and unifies the code used to obtain a Signer for a tx.
roysc commented 2023-06-10 08:25:33 +00:00
Owner
Copy link
Copy source

So this was only triggered on EIP-2718 (post Berlin?) transactions? This reminds me, the API unit tests don't cover them, I wanted to make an issue for that

So this was only triggered on EIP-2718 (post Berlin?) transactions? This reminds me, the API unit tests don't cover them, I wanted to make an issue for that
i-norden commented 2023-06-12 12:58:54 +00:00
Member
Copy link
Copy source

@roysc yeah also the integration tests comparing geth results to ipld-eth-server results compare responses from getTransactionReceipt after the JSON returned by theses endpoints has been unpacked into a *types.Receipt, which does not have a "from" field. We should be comparing the full JSON responses.

@roysc yeah also the integration tests comparing geth results to ipld-eth-server results compare responses from `getTransactionReceipt` *after* the JSON returned by theses endpoints has been unpacked into a `*types.Receipt`, which does not have a "from" field. We should be comparing the full JSON responses.
👍 1
i-norden approved these changes 2023-06-12 12:59:23 +00:00
i-norden left a comment
Member
Copy link
Copy source

LGTM, thanks. Will create an issue for improved test coverage.

LGTM, thanks. Will create an issue for improved test coverage.
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#242