Fix for getTransactionReceipt returning empty 'from' address. #242

telackey · 2023-06-09T23:52:46Z

telackey commented

2023-06-09 23:52:46 +00:00

Fixes a bug where the wrong signer is used for getTransactionReceipt, leading to a null 'from' value, and unifies the code used to obtain a Signer for a tx.

roysc commented

2023-06-10 08:25:33 +00:00

So this was only triggered on EIP-2718 (post Berlin?) transactions? This reminds me, the API unit tests don't cover them, I wanted to make an issue for that

i-norden commented

2023-06-12 12:58:54 +00:00

@roysc yeah also the integration tests comparing geth results to ipld-eth-server results compare responses from getTransactionReceipt after the JSON returned by theses endpoints has been unpacked into a *types.Receipt, which does not have a "from" field. We should be comparing the full JSON responses.

@roysc yeah also the integration tests comparing geth results to ipld-eth-server results compare responses from `getTransactionReceipt` *after* the JSON returned by theses endpoints has been unpacked into a `*types.Receipt`, which does not have a "from" field. We should be comparing the full JSON responses.

👍 1

i-norden approved these changes 2023-06-12 12:59:23 +00:00

i-norden left a comment

LGTM, thanks. Will create an issue for improved test coverage.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#242