Add option to forward eth_getStorageAt calls. #221

Merged

telackey merged 7 commits from telackey/pxy_get_storage_at into v4 2023-01-10 23:39:21 +00:00

Conversation 2 Commits 7 Files Changed 6

+54 -31

telackey commented 2023-01-10 18:05:13 +00:00

Contributor

Copy Link

Copy Source

Add a new option etherum.forwardGetStorageAt / ETH_FORWARD_GET_STORAGE_AT to toggle proxying all eth_getStorageAt calls to geth.

It is analogous to the ETH_FORWARD_ETH_CALLS config setting, but for eth_getStorageAt rather than eth_call.

It is helpful to ameliorate to https://github.com/cerc-io/go-ethereum/issues/296, https://github.com/cerc-io/go-ethereum/issues/293, etc. while those issues are addressed.

Add a new option `etherum.forwardGetStorageAt` / `ETH_FORWARD_GET_STORAGE_AT` to toggle proxying all `eth_getStorageAt` calls to `geth`. It is analogous to the `ETH_FORWARD_ETH_CALLS` config setting, but for `eth_getStorageAt` rather than `eth_call`. It is helpful to ameliorate to https://github.com/cerc-io/go-ethereum/issues/296, https://github.com/cerc-io/go-ethereum/issues/293, etc. while those issues are addressed.

dboreham reviewed 2023-01-10 18:05:13 +00:00

i-norden approved these changes 2023-01-10 23:37:21 +00:00

i-norden left a comment

Member

Copy Link

Copy Source

LGTM!

I seem to be experiencing a github UI bug, it shows Erik's notion sync commit from 6 months ago as being in this PR (and my PR based on this one).

LGTM! I seem to be experiencing a github UI bug, it shows Erik's notion sync commit from 6 months ago as being in this PR (and my PR based on this one).

Sign in to join this conversation.

Reviewers

No Reviewers

dboreham

i-norden

Labels

Clear labels

Epic

Integration tests

bug

Something isn't working

critical

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

v5

wontfix

This will not be worked on

Copied from Github

An issue or PR manually copied from GitHub.

Kind/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

AFDudley Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#221