211: ipld-eth-server http counters don't work #212

telackey · 2022-12-23T19:43:37Z

telackey commented

2022-12-23 19:43:37 +00:00

Enable HTTP metrics. More detail is in #211, but the necessary metrics code already existed, it just doesn't seem to be used.

❤️ 1

prathamesh0 (Migrated from github.com) reviewed 2022-12-23 19:43:37 +00:00

dboreham approved these changes 2022-12-23 19:52:04 +00:00

dboreham left a comment

Are there any security concerns with this? I think in another project we ran the metrics on a separate port from main traffic.

telackey commented

2022-12-23 19:57:27 +00:00

Are there any security concerns with this? I think in another project we ran the metrics on a separate port from main traffic.

It runs on a separate port (default 8090). The problem in this case is that the counters weren't moving, because the way they are implemented is as as simple wrapper that does (roughly):

counter.start()
real_handler_goes_here.doStuff()
counter.stop()

But we weren't using the wrapper for HTTP, though we are for WS and IPC.

> Are there any security concerns with this? I think in another project we ran the metrics on a separate port from main traffic. It runs on a separate port (default 8090). The problem in this case is that the counters weren't moving, because the way they are implemented is as as simple wrapper that does (roughly): ``` counter.start() real_handler_goes_here.doStuff() counter.stop() ``` But we weren't using the wrapper for HTTP, though we are for WS and IPC.

Sign in to join this conversation.

No reviewers

prathamesh0

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#212