cerc-io/ipld-eth-server
12
0 Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

Use geth's eth API instead of ethclient on missing blocks for getHeaderByHash #181

Merged
prathamesh0 merged 1 commits from pm-change-getheaderbyhash into sharding 2022-07-20 04:04:44 +00:00
Conversation 1 Commits 1 Files Changed 1
+3 -4
prathamesh0 commented 2022-07-19 15:03:02 +00:00 (Migrated from github.com)
Copy link
Copy source

Part of https://github.com/vulcanize/ipld-eth-server/issues/180

  • Use geth's eth API instead of ethclient on missing blocks for getHeaderByHash
    • To maintain compatibility with geth's eth API, GetHeaderByHash() is required to include totalDifficulty in the result
    • ethclient's HeaderByHash method returns just the header object which doesn't have the totalDifficulty
    • Since geth's getHeaderByHash API implementation includes totalDifficulty in the result, it is not required to be fetched separately
Part of https://github.com/vulcanize/ipld-eth-server/issues/180 - Use geth's eth API instead of ethclient on missing blocks for `getHeaderByHash` - To maintain compatibility with geth's eth API, `GetHeaderByHash()` is required to include `totalDifficulty` in the result - ethclient's `HeaderByHash` [method](https://github.com/ethereum/go-ethereum/blob/v1.10.20/ethclient/ethclient.go#L176) returns just the header object which doesn't have the `totalDifficulty` - Since geth's `getHeaderByHash` API [implementation](https://github.com/ethereum/go-ethereum/blob/v1.10.20/internal/ethapi/api.go#L708) includes `totalDifficulty` in the result, it is not required to be fetched separately
ashwinphatak (Migrated from github.com) approved these changes 2022-07-20 04:04:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ashwinphatak
Labels
Clear labels
Epic
Integration tests
bug
Something isn't working
 critical
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 v5
wontfix
This will not be worked on
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#181