cerc-io/ipld-eth-server
18
0
Fork 1
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 37 Wiki Activity

Do call #11

Merged
telackey merged 7 commits from do_call into master 2020-10-21 02:21:33 +00:00
Conversation 5 Commits 7 Files Changed 34 +2275 -717
i-norden commented 2020-09-25 14:00:38 +00:00
Member
Copy Link

Adding eth_Call endpoint to ipld-eth-server.

See #10

Included in this work are some Postgres functions for retrieving the canonical header at a provided height (based on weight).

Adding `eth_Call` endpoint to ipld-eth-server. See #10 Included in this work are some Postgres functions for retrieving the canonical header at a provided height (based on weight).
AFDudley reviewed 2020-09-25 14:00:38 +00:00
ramilexe commented 2020-09-29 15:53:53 +00:00 (Migrated from github.com)
Copy Link

https://github.com/vulcanize/ipld-eth-server/issues/10

https://github.com/vulcanize/ipld-eth-server/issues/10
i-norden commented 2020-10-07 14:03:33 +00:00
Author
Member
Copy Link

This is ostensibly completed, but I need to write unit tests. This is cumbersome because we need to generate sufficient state to perform the eth_Call operations on to test them.

This is ostensibly completed, but I need to write unit tests. This is cumbersome because we need to generate sufficient state to perform the eth_Call operations on to test them.
i-norden commented 2020-10-07 17:46:29 +00:00
Author
Member
Copy Link

In addition to tests, #13 and #14 required to consider this complete

In addition to tests, #13 and #14 required to consider this complete
i-norden commented 2020-10-09 15:48:16 +00:00
Author
Member
Copy Link

https://github.com/vulcanize/ipld-eth-indexer/issues/27 is blocking this, otherwise the tests are passing

https://github.com/vulcanize/ipld-eth-indexer/issues/27 is blocking this, otherwise the tests are passing
ramilexe (Migrated from github.com) reviewed 2020-10-14 15:07:13 +00:00
pkg/eth/backend.go
@ -29,3 +34,4 @@
"github.com/ethereum/go-ethereum/params"
"github.com/ethereum/go-ethereum/rlp"
"github.com/ethereum/go-ethereum/rpc"
ipfsethdb "github.com/vulcanize/pg-ipfs-ethdb"
ramilexe (Migrated from github.com) commented 2020-10-14 14:54:32 +00:00
Copy Link

this repo was renamed to github.com/vulcanize/ipfs-ethdb shouldn't we update import as well?

this repo was renamed to `github.com/vulcanize/ipfs-ethdb` shouldn't we update import as well?
pkg/eth/backend.go
ramilexe (Migrated from github.com) commented 2020-10-14 15:01:43 +00:00
Copy Link

Isn't better to return some error/exception/panic?

Isn't better to return some error/exception/panic?
pkg/eth/eth_call_test.go
@ -0,0 +148,4 @@
}
res, err := api.Call(context.Background(), callArgs, rpc.BlockNumberOrHashWithNumber(2), nil)
Expect(err).ToNot(HaveOccurred())
expectedRes := hexutil.Bytes(common.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000001"))
ramilexe (Migrated from github.com) commented 2020-10-14 15:05:11 +00:00
Copy Link

where is the definition that for data input and block number 2 we will have this result?

where is the definition that for `data` input and block number 2 we will have this result?
i-norden reviewed 2020-10-14 16:50:00 +00:00
pkg/eth/backend.go
@ -29,3 +34,4 @@
"github.com/ethereum/go-ethereum/params"
"github.com/ethereum/go-ethereum/rlp"
"github.com/ethereum/go-ethereum/rpc"
ipfsethdb "github.com/vulcanize/pg-ipfs-ethdb"
i-norden commented 2020-10-14 16:50:00 +00:00
Author
Member
Copy Link

We're using an early tagged release of that repo where the package is exported as github.com/vulcanize/pg-ipfs-ethdb, because it is the version that is compatible with geth 1.9.11 (what our statediffing geth is currently rebased ontop of)

We're using an early tagged release of that repo where the package is exported as `github.com/vulcanize/pg-ipfs-ethdb`, because it is the version that is compatible with geth 1.9.11 (what our statediffing geth is currently rebased ontop of)
i-norden reviewed 2020-10-14 16:53:16 +00:00
pkg/eth/backend.go
i-norden commented 2020-10-14 16:53:16 +00:00
Author
Member
Copy Link

ethash.NewFaker() is the correct thing to return in the case of mainnet and some other PoW chains, but PoA (Clique) chains need to return a different engine.

ethash.NewFaker() is the correct thing to return in the case of mainnet and some other PoW chains, but PoA (Clique) chains need to return a different engine.
i-norden reviewed 2020-10-14 16:54:37 +00:00
pkg/eth/eth_call_test.go
@ -0,0 +148,4 @@
}
res, err := api.Call(context.Background(), callArgs, rpc.BlockNumberOrHashWithNumber(2), nil)
Expect(err).ToNot(HaveOccurred())
expectedRes := hexutil.Bytes(common.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000001"))
i-norden commented 2020-10-14 16:54:37 +00:00
Author
Member
Copy Link

This is the value set in the contract init: https://github.com/vulcanize/ipld-eth-server/blob/do_call/pkg/eth/test_helpers/test_contract.sol#L18
The other values are set in the chain maker txs: e.g. https://github.com/vulcanize/ipld-eth-server/blob/do_call/pkg/eth/test_helpers/chain_maker.go#L85

This is the value set in the contract init: https://github.com/vulcanize/ipld-eth-server/blob/do_call/pkg/eth/test_helpers/test_contract.sol#L18 The other values are set in the chain maker txs: e.g. https://github.com/vulcanize/ipld-eth-server/blob/do_call/pkg/eth/test_helpers/chain_maker.go#L85
ramilexe (Migrated from github.com) reviewed 2020-10-14 18:12:16 +00:00
pkg/eth/eth_call_test.go
@ -0,0 +148,4 @@
}
res, err := api.Call(context.Background(), callArgs, rpc.BlockNumberOrHashWithNumber(2), nil)
Expect(err).ToNot(HaveOccurred())
expectedRes := hexutil.Bytes(common.Hex2Bytes("0000000000000000000000000000000000000000000000000000000000000001"))
ramilexe (Migrated from github.com) commented 2020-10-14 18:12:16 +00:00
Copy Link

Thanks!

Thanks!
ramilexe (Migrated from github.com) reviewed 2020-10-21 00:07:37 +00:00
go.mod
ramilexe (Migrated from github.com) commented 2020-10-21 00:07:36 +00:00
Copy Link

Full path doesn't work in CI

Full path doesn't work in CI
i-norden reviewed 2020-10-21 02:14:38 +00:00
go.mod
i-norden commented 2020-10-21 02:14:38 +00:00
Author
Member
Copy Link

Yeah I had to wait for https://github.com/vulcanize/ipld-eth-indexer/releases/tag/v0.6.0-alpha, was just stashing on the remote, updated it now

Yeah I had to wait for https://github.com/vulcanize/ipld-eth-indexer/releases/tag/v0.6.0-alpha, was just stashing on the remote, updated it now
i-norden commented 2020-10-21 02:18:23 +00:00
Author
Member
Copy Link

https://github.com/vulcanize/ipld-eth-indexer/releases/tag/v0.6.0-alpha is cut. Updated to use it and eth_call and rest of the tests are passing.

https://github.com/vulcanize/ipld-eth-indexer/releases/tag/v0.6.0-alpha is cut. Updated to use it and eth_call and rest of the tests are passing.
Sign in to join this conversation.
Reviewers
No reviewers
AFDudley
Labels
Clear labels   
bug

Something isn't working

  
critical

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
Epic

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
Integration tests

   
invalid

This doesn't seem right

  
question

Further information is requested

  
v5

   
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
critical
documentation
duplicate
enhancement
Epic
good first issue
help wanted
Integration tests
invalid
question
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#11
No description provided.
Delete Branch "do_call"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?