cerc-io/ipld-eth-server
17
0
Fork 1
Code Issues 10 Pull Requests 1 Actions Packages Projects Releases 37 Wiki Activity

Dedup receipt #103

Merged
arijitAD merged 6 commits from dedup-receipt into master 2021-09-22 10:22:02 +00:00
Conversation 0 Commits 6 Files Changed 16 +272 -147
arijitAD commented 2021-09-17 11:59:05 +00:00 (Migrated from github.com)
Copy Link
No description provided.
ashwinphatak (Migrated from github.com) reviewed 2021-09-17 11:59:05 +00:00
i-norden approved these changes 2021-09-17 13:02:24 +00:00
i-norden left a comment
Member
Copy Link

Just a few minor comments and a question, thanks!

Just a few minor comments and a question, thanks!
pkg/eth/cid_retriever.go
i-norden commented 2021-09-17 13:00:24 +00:00
Member
Copy Link

Brain is foggy and I'm not reasoning about this well atm, why are we changing this condition from log_cids.leaf_mh_key = blocks.key to receipt_cids.leaf_mh_key = blocks.key?

Brain is foggy and I'm not reasoning about this well atm, why are we changing this condition from `log_cids.leaf_mh_key = blocks.key` to `receipt_cids.leaf_mh_key = blocks.key`?
pkg/eth/filterer.go
i-norden commented 2021-09-17 12:55:42 +00:00
Member
Copy Link

I think this should be renamed. It isn't fetching anything from a db or remote source.

I think this should be renamed. It isn't fetching anything from a db or remote source.
pkg/eth/ipld_retriever.go
@ -351,1 +383,4 @@
return nil, nil, nil, err
}
rcts[i] = nodeVal
txs[i] = common.HexToHash(res.TxHash)
i-norden commented 2021-09-17 12:57:22 +00:00
Member
Copy Link

Lets remove this comment

Lets remove this comment
pkg/eth/ipld_retriever.go
@ -362,4 +398,4 @@
}
cids := make([]string, len(rctResults))
rcts := make([][]byte, len(rctResults))
for i, res := range rctResults {
i-norden commented 2021-09-17 12:57:39 +00:00
Member
Copy Link

Ditto

Ditto
i-norden commented 2021-09-17 13:01:57 +00:00
Member
Copy Link

We may want to note that the CIDs we are returning is not for the Receipts themselves but rather the leaf nodes they are contained within

We may want to note that the CIDs we are returning is not for the Receipts themselves but rather the leaf nodes they are contained within
i-norden commented 2021-09-17 13:02:03 +00:00
Member
Copy Link

We may want to note that the CID we are returning is not for the Receipt itself but rather the leaf node it was contained within

We may want to note that the CID we are returning is not for the Receipt itself but rather the leaf node it was contained within
pkg/eth/test_helpers.go
@ -56,10 +56,10 @@ func TxModelsContainsCID(txs []models.TxModel, cid string) bool {
return false
}
i-norden commented 2021-09-17 12:59:23 +00:00
Member
Copy Link

Not introduced here but I notice this comment is outdated, let's align it with the function

Not introduced here but I notice this comment is outdated, let's align it with the function
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:09:13 +00:00
pkg/eth/filterer.go
arijitAD (Migrated from github.com) commented 2021-09-20 10:09:13 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:09:53 +00:00
pkg/eth/ipld_retriever.go
@ -351,1 +383,4 @@
return nil, nil, nil, err
}
rcts[i] = nodeVal
txs[i] = common.HexToHash(res.TxHash)
arijitAD (Migrated from github.com) commented 2021-09-20 10:09:53 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:09:58 +00:00
pkg/eth/ipld_retriever.go
@ -362,4 +398,4 @@
}
cids := make([]string, len(rctResults))
rcts := make([][]byte, len(rctResults))
for i, res := range rctResults {
arijitAD (Migrated from github.com) commented 2021-09-20 10:09:58 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:11:07 +00:00
pkg/eth/test_helpers.go
@ -56,10 +56,10 @@ func TxModelsContainsCID(txs []models.TxModel, cid string) bool {
return false
}
arijitAD (Migrated from github.com) commented 2021-09-20 10:11:07 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:15:23 +00:00
pkg/eth/ipld_retriever.go
@ -362,4 +398,4 @@
}
cids := make([]string, len(rctResults))
rcts := make([][]byte, len(rctResults))
for i, res := range rctResults {
arijitAD (Migrated from github.com) commented 2021-09-20 10:15:23 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:21:05 +00:00
pkg/eth/ipld_retriever.go
@ -362,4 +398,4 @@
}
cids := make([]string, len(rctResults))
rcts := make([][]byte, len(rctResults))
for i, res := range rctResults {
arijitAD (Migrated from github.com) commented 2021-09-20 10:21:04 +00:00
Copy Link

Done

Done
arijitAD (Migrated from github.com) reviewed 2021-09-20 10:30:12 +00:00
pkg/eth/cid_retriever.go
arijitAD (Migrated from github.com) commented 2021-09-20 10:30:12 +00:00
Copy Link

Reverted.

Reverted.
Sign in to join this conversation.
Reviewers
No reviewers
i-norden
ashwinphatak
Labels
Clear labels   
bug

Something isn't working

  
critical

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
Epic

   
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
Integration tests

   
invalid

This doesn't seem right

  
question

Further information is requested

  
v5

   
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
critical
documentation
duplicate
enhancement
Epic
good first issue
help wanted
Integration tests
invalid
question
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-server#103
No description provided.
Delete Branch "dedup-receipt"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?