Prefer all caps for initialisms and acronyms

pkg/eth/cold_import/importer.go

@@ -38,16 +38,16 @@ func NewColdImporter(ethDB ethereum.Database, blockRepository datastore.BlockRep
 	}
 }
 
-func (ci *ColdImporter) Execute(startingBlockNumber int64, endingBlockNumber int64, nodeId string) error {
-	missingBlocks := ci.blockRepository.MissingBlockNumbers(startingBlockNumber, endingBlockNumber, nodeId)
+func (ci *ColdImporter) Execute(startingBlockNumber int64, endingBlockNumber int64, nodeID string) error {
+	missingBlocks := ci.blockRepository.MissingBlockNumbers(startingBlockNumber, endingBlockNumber, nodeID)
 	for _, n := range missingBlocks {
 		hash := ci.ethDB.GetBlockHash(n)
 
-		blockId, err := ci.createBlocksAndTransactions(hash, n)
+		blockID, err := ci.createBlocksAndTransactions(hash, n)
 		if err != nil {
 			return err
 		}
-		err = ci.createReceiptsAndLogs(hash, n, blockId)
+		err = ci.createReceiptsAndLogs(hash, n, blockID)
 		if err != nil {
 			return err
 		}
@@ -65,11 +65,11 @@ func (ci *ColdImporter) createBlocksAndTransactions(hash []byte, i int64) (int64
 	return ci.blockRepository.CreateOrUpdateBlock(coreBlock)
 }
 
-func (ci *ColdImporter) createReceiptsAndLogs(hash []byte, number int64, blockId int64) error {
+func (ci *ColdImporter) createReceiptsAndLogs(hash []byte, number int64, blockID int64) error {
 	receipts := ci.ethDB.GetBlockReceipts(hash, number)
 	coreReceipts, err := common.ToCoreReceipts(receipts)
 	if err != nil {
 		return err
 	}
-	return ci.receiptRepository.CreateReceiptsAndLogs(blockId, coreReceipts)
+	return ci.receiptRepository.CreateReceiptsAndLogs(blockID, coreReceipts)
 }

pkg/eth/cold_import/node_builder.go

@@ -27,7 +27,7 @@ import (
 
 const (
 	ColdImportClientName         = "LevelDbColdImport"
-	ColdImportNetworkId  float64 = 1
+	ColdImportNetworkID  float64 = 1
 )
 
 var (
@@ -54,15 +54,15 @@ func (cinb ColdImportNodeBuilder) GetNode(genesisBlock []byte, levelPath string)
 	if err != nil {
 		return coldNode, err
 	}
-	nodeId, err := cinb.parser.ParsePublicKey(string(nodeKey))
+	nodeID, err := cinb.parser.ParsePublicKey(string(nodeKey))
 	if err != nil {
 		return coldNode, err
 	}
 	genesisBlockHash := common.BytesToHash(genesisBlock).String()
 	coldNode = core.Node{
 		GenesisBlock: genesisBlockHash,
-		NetworkID:    ColdImportNetworkId,
-		ID:           nodeId,
+		NetworkID:    ColdImportNetworkID,
+		ID:           nodeID,
 		ClientName:   ColdImportClientName,
 	}
 	return coldNode, nil

pkg/eth/cold_import/node_builder_test.go

@@ -106,7 +106,7 @@ var _ = Describe("Cold importer node builder", func() {
 			expectedGenesisBlock := common.BytesToHash(fakeGenesisBlock).String()
 			Expect(result.GenesisBlock).To(Equal(expectedGenesisBlock))
 			Expect(result.ID).To(Equal(fakePublicKeyString))
-			Expect(result.NetworkID).To(Equal(cold_import.ColdImportNetworkId))
+			Expect(result.NetworkID).To(Equal(cold_import.ColdImportNetworkID))
 		})
 	})