Remove watched addresses fill service code

2022-05-23 10:37:59 +05:30
parent be34f0e8fd
commit c25d220f71
16 changed files with 5 additions and 1142 deletions
@@ -4,10 +4,10 @@

 - Clone [stack-orchestrator](https://github.com/vulcanize/stack-orchestrator) and [go-ethereum](https://github.com/vulcanize/go-ethereum) repositories.

- Checkout [v3 release](https://github.com/vulcanize/go-ethereum/releases/tag/v1.10.17-statediff-3.2.0) in go-ethereum repo.
+- Checkout [v3 release](https://github.com/vulcanize/go-ethereum/releases/tag/v1.10.17-statediff-3.2.1) in go-ethereum repo.
  ```bash
  # In go-ethereum repo.
-  git checkout v1.10.17-statediff-3.2.0
+  git checkout v1.10.17-statediff-3.2.1
  ```

 - Checkout working commit in stack-orchestrator repo.
@@ -85,28 +85,3 @@
    ```bash
    ./scripts/run_integration_test_forward_eth_calls.sh
    ```
-
-  - Update `config.sh` file:
-    ```bash
-    #!/bin/bash
-
-    # Path to go-ethereum repo.
-    vulcanize_go_ethereum=~/go-ethereum/
-
-    # Path to ipld-eth-server repo.
-    vulcanize_ipld_eth_server=~/ipld-eth-server/
-
-    db_write=true
-    eth_forward_eth_calls=false
-    eth_proxy_on_error=false
-    eth_http_path="go-ethereum:8545"
-    watched_addres_gap_filler_enabled=true
-    watched_addres_gap_filler_interval=5
-    ```
-
-  - Stop the stack-orchestrator and start again using the same command
-
-  - Run integration tests for watched addresses with gap filling service enabled:
-    ```bash
-    ./scripts/run_integration_test_watched_address_gap_filler.sh
-    ```
@@ -20,8 +20,6 @@ import (
 var _ = Describe("Integration test", func() {
 	directProxyEthCalls, err := strconv.ParseBool(os.Getenv("ETH_FORWARD_ETH_CALLS"))
 	Expect(err).To(BeNil())
-	watchedAddressServiceEnabled, err := strconv.ParseBool(os.Getenv("WATCHED_ADDRESS_GAP_FILLER_ENABLED"))
-	Expect(err).To(BeNil())
 	gethHttpPath := "http://127.0.0.1:8545"
 	gethClient, err := ethclient.Dial(gethHttpPath)
 	Expect(err).ToNot(HaveOccurred())
@@ -41,7 +39,7 @@ var _ = Describe("Integration test", func() {
 	sleepInterval := 2 * time.Second

 	BeforeEach(func() {
-		if !directProxyEthCalls || watchedAddressServiceEnabled {
+		if !directProxyEthCalls {
 			Skip("skipping direct-proxy-forwarding integration tests")
 		}
 	})
@@ -31,8 +31,6 @@ var (
 var _ = Describe("Integration test", func() {
 	directProxyEthCalls, err := strconv.ParseBool(os.Getenv("ETH_FORWARD_ETH_CALLS"))
 	Expect(err).To(BeNil())
-	watchedAddressServiceEnabled, err := strconv.ParseBool(os.Getenv("WATCHED_ADDRESS_GAP_FILLER_ENABLED"))
-	Expect(err).To(BeNil())
 	gethHttpPath := "http://127.0.0.1:8545"
 	gethClient, err := ethclient.Dial(gethHttpPath)
 	Expect(err).ToNot(HaveOccurred())
@@ -52,7 +50,7 @@ var _ = Describe("Integration test", func() {
 	sleepInterval := 2 * time.Second

 	BeforeEach(func() {
-		if directProxyEthCalls || watchedAddressServiceEnabled {
+		if directProxyEthCalls {
 			Skip("skipping no-direct-proxy-forwarding integration tests")
 		}
 	})
@@ -28,9 +28,6 @@ var _ = Describe("WatchAddress integration test", func() {
 	dbWrite, err := strconv.ParseBool(os.Getenv("DB_WRITE"))
 	Expect(err).To(BeNil())

-	watchedAddressServiceEnabled, err := strconv.ParseBool(os.Getenv("WATCHED_ADDRESS_GAP_FILLER_ENABLED"))
-	Expect(err).To(BeNil())
-
 	gethHttpPath := "http://127.0.0.1:8545"
 	gethRPCClient, err := rpc.Dial(gethHttpPath)
 	Expect(err).ToNot(HaveOccurred())
@@ -72,7 +69,7 @@ var _ = Describe("WatchAddress integration test", func() {
 	)

 	BeforeEach(func() {
-		if !dbWrite || watchedAddressServiceEnabled {
+		if !dbWrite {
 			Skip("skipping WatchAddress API integration tests")
 		}
 	})
@@ -1,318 +0,0 @@
-package integration_test
-
-import (
-	"context"
-	"math/big"
-	"os"
-	"strconv"
-	"time"
-
-	"github.com/ethereum/go-ethereum/common"
-	"github.com/ethereum/go-ethereum/ethclient"
-	"github.com/ethereum/go-ethereum/rpc"
-	"github.com/ethereum/go-ethereum/statediff/types"
-	. "github.com/onsi/ginkgo"
-	. "github.com/onsi/gomega"
-
-	integration "github.com/vulcanize/ipld-eth-server/v3/test"
-)
-
-var _ = Describe("Watched address gap filling service integration test", func() {
-	dbWrite, err := strconv.ParseBool(os.Getenv("DB_WRITE"))
-	Expect(err).To(BeNil())
-
-	watchedAddressServiceEnabled, err := strconv.ParseBool(os.Getenv("WATCHED_ADDRESS_GAP_FILLER_ENABLED"))
-	Expect(err).To(BeNil())
-
-	serviceInterval, err := strconv.ParseInt(os.Getenv("WATCHED_ADDRESS_GAP_FILLER_INTERVAL"), 10, 0)
-	Expect(err).To(BeNil())
-
-	gethHttpPath := "http://127.0.0.1:8545"
-	gethRPCClient, err := rpc.Dial(gethHttpPath)
-	Expect(err).ToNot(HaveOccurred())
-
-	ipldEthHttpPath := "http://127.0.0.1:8081"
-	ipldClient, err := ethclient.Dial(ipldEthHttpPath)
-	Expect(err).ToNot(HaveOccurred())
-	ipldRPCClient, err := rpc.Dial(ipldEthHttpPath)
-	Expect(err).ToNot(HaveOccurred())
-
-	var (
-		ctx = context.Background()
-
-		contractErr error
-		txErr       error
-
-		GLD1 *integration.ContractDeployed
-		SLV1 *integration.ContractDeployed
-		SLV2 *integration.ContractDeployed
-
-		countAIndex string
-		countBIndex string
-
-		oldCountA1 = big.NewInt(0)
-		oldCountA2 = big.NewInt(0)
-		oldCountB2 = big.NewInt(0)
-
-		updatedCountA1 = big.NewInt(1)
-		updatedCountA2 = big.NewInt(1)
-		updatedCountB2 = big.NewInt(1)
-
-		SLV2CountBIncrementedAt *integration.CountIncremented
-
-		contract1Salt = "contract1SLV"
-	)
-
-	BeforeEach(func() {
-		if !dbWrite || !watchedAddressServiceEnabled {
-			Skip("skipping watched address gap filling service integration tests")
-		}
-	})
-
-	It("test init", func() {
-		// Clear out watched addresses
-		err := integration.ClearWatchedAddresses(gethRPCClient)
-		Expect(err).ToNot(HaveOccurred())
-
-		// Deploy a GLD contract
-		GLD1, contractErr = integration.DeployContract()
-		Expect(contractErr).ToNot(HaveOccurred())
-
-		// Watch GLD1 contract
-		operation := types.Add
-		args := []types.WatchAddressArg{
-			{
-				Address:   GLD1.Address,
-				CreatedAt: uint64(GLD1.BlockNumber),
-			},
-		}
-		ipldErr := ipldRPCClient.Call(nil, ipldMethod, operation, args)
-		Expect(ipldErr).ToNot(HaveOccurred())
-
-		// Deploy two SLV contracts and update storage slots
-		SLV1, contractErr = integration.Create2Contract("SLVToken", contract1Salt)
-		Expect(contractErr).ToNot(HaveOccurred())
-
-		_, txErr = integration.IncrementCount(SLV1.Address, "A")
-		Expect(txErr).ToNot(HaveOccurred())
-
-		SLV2, contractErr = integration.DeploySLVContract()
-		Expect(contractErr).ToNot(HaveOccurred())
-
-		_, txErr = integration.IncrementCount(SLV2.Address, "A")
-		Expect(txErr).ToNot(HaveOccurred())
-		SLV2CountBIncrementedAt, txErr = integration.IncrementCount(SLV2.Address, "B")
-		Expect(txErr).ToNot(HaveOccurred())
-
-		// Get storage slot keys
-		storageSlotAKey, err := integration.GetStorageSlotKey("SLVToken", "countA")
-		Expect(err).ToNot(HaveOccurred())
-		countAIndex = storageSlotAKey.Key
-
-		storageSlotBKey, err := integration.GetStorageSlotKey("SLVToken", "countB")
-		Expect(err).ToNot(HaveOccurred())
-		countBIndex = storageSlotBKey.Key
-	})
-
-	defer It("test cleanup", func() {
-		// Destroy create2 contract
-		_, err := integration.DestroySLVContract(SLV1.Address)
-		Expect(err).ToNot(HaveOccurred())
-
-		// Clear out watched addresses
-		err = integration.ClearWatchedAddresses(gethRPCClient)
-		Expect(err).ToNot(HaveOccurred())
-	})
-
-	Context("previously unwatched contract watched", func() {
-		It("indexes state only for watched contract", func() {
-			// WatchedAddresses = [GLD1]
-			// SLV1, countA
-			countA1Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV1.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA1 := new(big.Int).SetBytes(countA1Storage)
-			Expect(countA1.String()).To(Equal(oldCountA1.String()))
-
-			// SLV2, countA
-			countA2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA2 := new(big.Int).SetBytes(countA2Storage)
-			Expect(countA2.String()).To(Equal(oldCountA2.String()))
-
-			// SLV2, countB
-			countB2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countBIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countB2 := new(big.Int).SetBytes(countB2Storage)
-			Expect(countB2.String()).To(Equal(oldCountB2.String()))
-		})
-
-		It("indexes past state on watching a contract", func() {
-			// Watch SLV1 contract
-			args := []types.WatchAddressArg{
-				{
-					Address:   SLV1.Address,
-					CreatedAt: uint64(SLV1.BlockNumber),
-				},
-			}
-			ipldErr := ipldRPCClient.Call(nil, ipldMethod, types.Add, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// Sleep for service interval + few extra seconds
-			time.Sleep(time.Duration(serviceInterval+2) * time.Second)
-
-			// WatchedAddresses = [GLD1, SLV1]
-			// SLV1, countA
-			countA1Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV1.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA1 := new(big.Int).SetBytes(countA1Storage)
-			Expect(countA1.String()).To(Equal(updatedCountA1.String()))
-
-			// SLV2, countA
-			countA2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA2 := new(big.Int).SetBytes(countA2Storage)
-			Expect(countA2.String()).To(Equal(oldCountA2.String()))
-
-			// SLV2, countB
-			countB2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countBIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countB2 := new(big.Int).SetBytes(countB2Storage)
-			Expect(countB2.String()).To(Equal(oldCountB2.String()))
-		})
-	})
-
-	Context("previously unwatched contract watched (different 'created_at')", func() {
-		It("indexes past state from 'created_at' onwards on watching a contract", func() {
-			// Watch SLV2 (created_at -> countB incremented) contract
-			args := []types.WatchAddressArg{
-				{
-					Address:   SLV2.Address,
-					CreatedAt: uint64(SLV2CountBIncrementedAt.BlockNumber),
-				},
-			}
-			ipldErr := ipldRPCClient.Call(nil, ipldMethod, types.Add, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// Sleep for service interval + few extra seconds
-			time.Sleep(time.Duration(serviceInterval+2) * time.Second)
-
-			// WatchedAddresses = [GLD1, SLV1, SLV2]
-			// SLV2, countA
-			countA2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA2 := new(big.Int).SetBytes(countA2Storage)
-			Expect(countA2.String()).To(Equal(oldCountA2.String()))
-
-			// SLV2, countB
-			countB2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countBIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countB2 := new(big.Int).SetBytes(countB2Storage)
-			Expect(countB2.String()).To(Equal(updatedCountB2.String()))
-		})
-
-		It("indexes missing past state on watching a contract from an earlier 'created_at'", func() {
-			// Remove SLV2 (created_at -> countB incremented) watched contract
-			args := []types.WatchAddressArg{
-				{
-					Address:   SLV2.Address,
-					CreatedAt: uint64(SLV2CountBIncrementedAt.BlockNumber),
-				},
-			}
-			ipldErr := ipldRPCClient.Call(nil, ipldMethod, types.Remove, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// Watch SLV2 (created_at -> deployment) contract
-			args = []types.WatchAddressArg{
-				{
-					Address:   SLV2.Address,
-					CreatedAt: uint64(SLV2.BlockNumber),
-				},
-			}
-			ipldErr = ipldRPCClient.Call(nil, ipldMethod, types.Add, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// Sleep for service interval + few extra seconds
-			time.Sleep(time.Duration(serviceInterval+2) * time.Second)
-
-			// WatchedAddresses = [GLD1, SLV1, SLV2]
-			// SLV2, countA
-			countA2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA2 := new(big.Int).SetBytes(countA2Storage)
-			Expect(countA2.String()).To(Equal(updatedCountA2.String()))
-
-			// SLV2, countB
-			countB2Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV2.Address), common.HexToHash(countBIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countB2 := new(big.Int).SetBytes(countB2Storage)
-			Expect(countB2.String()).To(Equal(updatedCountB2.String()))
-		})
-	})
-
-	Context("destroyed contract redeployed and watched", func() {
-		It("returns zero value for destroyed contract", func() {
-			_, err := integration.DestroySLVContract(SLV1.Address)
-			Expect(err).ToNot(HaveOccurred())
-
-			updatedCountA1 = big.NewInt(0)
-
-			operation := types.Remove
-			args := []types.WatchAddressArg{
-				{
-					Address:   SLV1.Address,
-					CreatedAt: uint64(SLV1.BlockNumber),
-				},
-			}
-			ipldErr := ipldRPCClient.Call(nil, ipldMethod, operation, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// WatchedAddresses = [GLD1, SLV2]
-			// SLV1, countA
-			countA1Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV1.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA1 := new(big.Int).SetBytes(countA1Storage)
-			Expect(countA1.String()).To(Equal(updatedCountA1.String()))
-			oldCountA1.Set(updatedCountA1)
-		})
-
-		It("indexes state for redeployed contract", func() {
-			// Redeploy contract
-			SLV1, contractErr = integration.Create2Contract("SLVToken", contract1Salt)
-			Expect(contractErr).ToNot(HaveOccurred())
-
-			// Add to watched address
-			operation := types.Add
-			args := []types.WatchAddressArg{
-				{
-					Address:   SLV1.Address,
-					CreatedAt: uint64(SLV1.BlockNumber),
-				},
-			}
-			ipldErr := ipldRPCClient.Call(nil, ipldMethod, operation, args)
-			Expect(ipldErr).ToNot(HaveOccurred())
-
-			// Sleep for service interval + few extra seconds
-			time.Sleep(time.Duration(serviceInterval+2) * time.Second)
-
-			// WatchedAddresses = [GLD1, SLV2, SLV1]
-			// SLV1, countA
-			countA1Storage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV1.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA1 := new(big.Int).SetBytes(countA1Storage)
-			Expect(countA1.String()).To(Equal(updatedCountA1.String()))
-			oldCountA1.Set(updatedCountA1)
-
-			// Update storage slots
-			_, txErr = integration.IncrementCount(SLV1.Address, "A")
-			time.Sleep(sleepInterval)
-			Expect(txErr).ToNot(HaveOccurred())
-			updatedCountA1.Add(updatedCountA1, big.NewInt(1))
-
-			countA1AfterIncrementStorage, err := ipldClient.StorageAt(ctx, common.HexToAddress(SLV1.Address), common.HexToHash(countAIndex), nil)
-			Expect(err).ToNot(HaveOccurred())
-			countA1AfterIncrement := new(big.Int).SetBytes(countA1AfterIncrementStorage)
-			Expect(countA1AfterIncrement.String()).To(Equal(updatedCountA1.String()))
-			oldCountA1.Set(updatedCountA1)
-		})
-	})
-})