cerc-io/ipld-eth-server
12
0
Fork 1
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 37 Wiki Activity

Prefer fmt.Errorf(s) to errors.New(fmt.Sprintf(s))

Browse Source
This commit is contained in:
Rob Mulholand
2019-10-31 13:33:39 -05:00
parent eb2f3c2209
commit 0ded7bcd62
5 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/plugin/builder/builder.go
+2 -3
View File
@@ -17,7 +17,6 @@
package builder
import (
"errors"
"fmt"
"os"
"os/exec"
@@ -68,7 +67,7 @@ func (b *builder) BuildPlugin() error {
// Build the .go file into a .so plugin
execErr := exec.Command("go", "build", "-buildmode=plugin", "-o", soFile, b.goFile).Run()
if execErr != nil {
return errors.New(fmt.Sprintf("unable to build .so file: %s", execErr.Error()))
return fmt.Errorf("unable to build .so file: %s", execErr.Error())
}
return nil
}
@@ -94,7 +93,7 @@ func (b *builder) setupBuildEnv() error {
copyErr := helpers.CopyDir(src, dst, "vendor")
if copyErr != nil {
return errors.New(fmt.Sprintf("unable to copy transformer dependency from %s to %s: %v", src, dst, copyErr))
return fmt.Errorf("unable to copy transformer dependency from %s to %s: %v", src, dst, copyErr)
}
// Have to clear out the copied over vendor lib or plugin won't build (see issue above)