Consider removing IPLDization of logs #3
Labels
No Label
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/ipld-eth-db#3
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
https://github.com/cerc-io/ipld-eth-db/issues/144
Internalize the logs data field into
eth.log_cids
. Renameeth.log_cids
toeth.logs
. Drop thecid
column. Will remove some data redundancy that currently exists betweeneth.log_cids
andipld.blocks
. As far I as I know, there is no need to reference or lookup individual logs by CID or expose them over IPFS in this capacity. Individual logs are never hashed into any of the canonical data structures, they exist within a list within a receipt (which is hashed into the receipt trie). This will involve making corresponding changes across the indexing software and ipld-eth-server, so is probably very low priority as the payoff for the amount of work required is low.