cerc-io/ipld-eth-beacon-indexer
19
0
Fork 0
Code Issues 4 Pull Requests 2 Actions Packages Projects Releases 9 Wiki Activity

[Bug] SSZ encoding returning an error #23

New Issue
Closed
opened 2022-04-27 18:04:48 +00:00 by abdulrabbani00 · 3 comments
abdulrabbani00 commented 2022-04-27 18:04:48 +00:00 (Migrated from github.com)
Copy Link

Table of contents generated with markdown-toc

Overview

Describe the bug

SSZ unmarshalling works to some degree. I am able to get most fields, but I am getting errors when unmarshalling "some" field. I need to figure out what those fields are and understand how to move forward.

To Reproduce

Steps to reproduce the behavior:

Run the tempHelper() function for the time being.

Expected behavior

To not get any errors when unmarshalling.

Evidence

Logs

Screenshots

Additional context

The error could be due to different API version...?

- [Overview](#overview) - [Describe the bug](#describe-the-bug) - [To Reproduce](#to-reproduce) - [Expected behavior](#expected-behavior) - [Evidence](#evidence) - [Logs](#logs) - [Screenshots](#screenshots) - [Additional context](#additional-context) <small><i><a href='http://ecotrust-canada.github.io/markdown-toc/'>Table of contents generated with markdown-toc</a></i></small> # Overview - **Requester**: @abdulrabbani00 - **Epic Link**: https://github.com/vulcanize/ipld-ethcl-indexer/issues/19 # Describe the bug <!--- A clear and concise description of what the bug is. ---> SSZ unmarshalling works to some degree. I am able to get most fields, but I am getting errors when unmarshalling "some" field. I need to figure out what those fields are and understand how to move forward. # To Reproduce Steps to reproduce the behavior: Run the `tempHelper()` function for the time being. <!--- 1. Go to '...' 2. Click on '....' 3. Scroll down to '....' 4. See error ---> # Expected behavior To not get any errors when unmarshalling. <!--- A clear and concise description of what you expected to happen. ---> # Evidence <!--- Provide any supporting documentation. ---> ## Logs <!--- Provide any logs if applicable. ---> ## Screenshots <!--- If applicable, add screenshots to help explain your problem. ---> # Additional context <!--- Add any other context about the problem here. ---> The error could be due to different API version...?
abdulrabbani00 commented 2022-04-28 20:19:03 +00:00 (Migrated from github.com)
Copy Link

I am not sure that this is something "worth" spending time on at this stage. A bit more insight regarding the issue:

  • When unmarshalling the SSZ data, I am able to get all the fields that I need.
    • At this point, the only field I need from the unmarshal is Slot.
  • There seems to be some error when unmarshalling nested fields.

The reason I don't think it is necessary to resolve this issue at the current moment is:

  • The field that we do need is being unmarshaled correctly.
  • We might never need to unmarshal the "troubling" field.
  • At this point we only need to capture the Slot, and write the entire SSZ object to the DB.

I think we should pick this ticket up if:

  • We need to unmarshal other fields.
  • The field we need to unmarshal has errors.
I am not sure that this is something "worth" spending time on at this stage. A bit more insight regarding the issue: * When unmarshalling the SSZ data, I am able to get all the fields that I need. * At this point, the only field I need from the unmarshal is `Slot`. * There seems to be some error when unmarshalling nested fields. The reason I don't think it is necessary to resolve this issue at the current moment is: * The field that we do need is being unmarshaled correctly. * We might never need to unmarshal the "troubling" field. * At this point we only need to capture the `Slot`, and write the entire SSZ object to the DB. I think we should pick this ticket up if: * We need to unmarshal other fields. * The field we need to unmarshal has errors.
abdulrabbani00 commented 2022-05-17 11:45:28 +00:00 (Migrated from github.com)
Copy Link

I am working to use the correct objects for each fork version. This should mitigate the issue.

I am working to use the correct objects for each fork version. This should mitigate the issue.
abdulrabbani00 commented 2022-05-17 14:33:41 +00:00 (Migrated from github.com)
Copy Link

We are using the provided interfaces to properly create structs depending on the fork version.

We are using the provided interfaces to properly create structs depending on the fork version.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
backlog

We will work on this at a later time.

  
beacon

   
bug

Something isn't working

  
critical

   
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
epic

An Epic

  
feature

We need a new feature

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
in review

   
invalid

This doesn't seem right

  
question

Further information is requested

  
test

We need to add test

  
wontfix

This will not be worked on

  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
backlog
beacon
bug
critical
documentation
duplicate
enhancement
epic
feature
good first issue
help wanted
in review
invalid
question
test
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/ipld-eth-beacon-indexer#23
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?