I am working on porting geth to [Ubuntu Core](https://developer.ubuntu.com/en/snappy/https://developer.ubuntu.com/en/snappy/). I am testing geth on a Raspberry PI and for Ubuntu Core the $HOME directory is unique for each application. See [here](https://developer.ubuntu.com/en/snappy/guides/filesystem-layout) for more information of their filesystem layout. For some reason in Go `usr.HomeDir` returns a different value than `$HOME` in Ubuntu Core. Adding this at the end of `HomeDir()` ```go fmt.Printf("at HomeDir, user.HomeDir = %s and $HOME is %s\n", usr.HomeDir, os.Getenv("HOME")) ``` gives the following output ``` at HomeDir, user.HomeDir = /home/ubuntu and $HOME is /home/ubuntu/apps/geth.sideload/IJcODREBYbHO ``` With this commit, I propose giving precedence to the `$HOME` environment variable as is also suggested by the [homedir](https://github.com/mitchellh/go-homedir/blob/master/homedir.go) project.
		
			
				
	
	
		
			98 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			98 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2014 The go-ethereum Authors
 | 
						|
// This file is part of the go-ethereum library.
 | 
						|
//
 | 
						|
// The go-ethereum library is free software: you can redistribute it and/or modify
 | 
						|
// it under the terms of the GNU Lesser General Public License as published by
 | 
						|
// the Free Software Foundation, either version 3 of the License, or
 | 
						|
// (at your option) any later version.
 | 
						|
//
 | 
						|
// The go-ethereum library is distributed in the hope that it will be useful,
 | 
						|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
 | 
						|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 | 
						|
// GNU Lesser General Public License for more details.
 | 
						|
//
 | 
						|
// You should have received a copy of the GNU Lesser General Public License
 | 
						|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 | 
						|
package common
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"os"
 | 
						|
	"os/user"
 | 
						|
	"path/filepath"
 | 
						|
	"runtime"
 | 
						|
	"strings"
 | 
						|
)
 | 
						|
 | 
						|
// MakeName creates a node name that follows the ethereum convention
 | 
						|
// for such names. It adds the operation system name and Go runtime version
 | 
						|
// the name.
 | 
						|
func MakeName(name, version string) string {
 | 
						|
	return fmt.Sprintf("%s/v%s/%s/%s", name, version, runtime.GOOS, runtime.Version())
 | 
						|
}
 | 
						|
 | 
						|
func ExpandHomePath(p string) (path string) {
 | 
						|
	path = p
 | 
						|
	sep := fmt.Sprintf("%s", os.PathSeparator)
 | 
						|
 | 
						|
	// Check in case of paths like "/something/~/something/"
 | 
						|
	if len(p) > 1 && p[:1+len(sep)] == "~"+sep {
 | 
						|
		usr, _ := user.Current()
 | 
						|
		dir := usr.HomeDir
 | 
						|
 | 
						|
		path = strings.Replace(p, "~", dir, 1)
 | 
						|
	}
 | 
						|
 | 
						|
	return
 | 
						|
}
 | 
						|
 | 
						|
func FileExist(filePath string) bool {
 | 
						|
	_, err := os.Stat(filePath)
 | 
						|
	if err != nil && os.IsNotExist(err) {
 | 
						|
		return false
 | 
						|
	}
 | 
						|
 | 
						|
	return true
 | 
						|
}
 | 
						|
 | 
						|
func AbsolutePath(Datadir string, filename string) string {
 | 
						|
	if filepath.IsAbs(filename) {
 | 
						|
		return filename
 | 
						|
	}
 | 
						|
	return filepath.Join(Datadir, filename)
 | 
						|
}
 | 
						|
 | 
						|
func HomeDir() string {
 | 
						|
	if home := os.Getenv("HOME"); home != "" {
 | 
						|
		return home
 | 
						|
	}
 | 
						|
	if usr, err := user.Current(); err == nil {
 | 
						|
		return usr.HomeDir
 | 
						|
	}
 | 
						|
	return ""
 | 
						|
}
 | 
						|
 | 
						|
func DefaultDataDir() string {
 | 
						|
	// Try to place the data folder in the user's home dir
 | 
						|
	home := HomeDir()
 | 
						|
	if home != "" {
 | 
						|
		if runtime.GOOS == "darwin" {
 | 
						|
			return filepath.Join(home, "Library", "Ethereum")
 | 
						|
		} else if runtime.GOOS == "windows" {
 | 
						|
			return filepath.Join(home, "AppData", "Roaming", "Ethereum")
 | 
						|
		} else {
 | 
						|
			return filepath.Join(home, ".ethereum")
 | 
						|
		}
 | 
						|
	}
 | 
						|
	// As we cannot guess a stable location, return empty and handle later
 | 
						|
	return ""
 | 
						|
}
 | 
						|
 | 
						|
func DefaultIpcPath() string {
 | 
						|
	if runtime.GOOS == "windows" {
 | 
						|
		return `\\.\pipe\geth.ipc`
 | 
						|
	}
 | 
						|
	return filepath.Join(DefaultDataDir(), "geth.ipc")
 | 
						|
}
 |