cerc-io/go-ethereum
13
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Write state diff to CSV #2

Merged
elizabethengelman merged 47 commits from ee-state-diff into statediff-for-archive-node 2019-01-28 21:31:02 +00:00
Conversation 0 Commits 47 Files Changed 90 +29 -12
3 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit dceddbfbaa - Show all commits

30
statediff/publisher/csv.go
View File

@ -8,12 +8,14 @@ import (
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
"strconv" "strconv"
"strings" "strings"
"time" "time"
"github.com/ethereum/go-ethereum/common"
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
) )
var ( var (
rmulhol commented 2019-01-03 22:59:58 +00:00 (Migrated from github.com)
Review
Copy Link

I think we probably want to include the address (and/or trie key) as a field here

I think we probably want to include the address (and/or trie key) as a field here
Headers = []string{ Headers = []string{
"blockNumber", "blockHash", "accountAction", "codeHash", "blockNumber", "blockHash", "accountAction", "codeHash",
"nonceValue", "balanceValue", "contractRoot", "storageDiffPaths", "nonceValue", "balanceValue", "contractRoot", "storageDiffPaths",
"accountAddress", "storageValue",
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
} }
timeStampFormat = "20060102150405.00000" timeStampFormat = "20060102150405.00000"
@ -67,8 +69,8 @@ func (p *publisher) publishStateDiffToCSV(sd builder.StateDiff) (string, error)
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
func accumulateUpdatedAccountRows(sd builder.StateDiff) [][]string { func accumulateUpdatedAccountRows(sd builder.StateDiff) [][]string {
var updatedAccountRows [][]string var updatedAccountRows [][]string
for _, accountDiff := range sd.UpdatedAccounts { for accountAddr, accountDiff := range sd.UpdatedAccounts {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
formattedAccountData := formatAccountDiffIncremental(accountDiff, sd, updatedAccountAction) formattedAccountData := formatAccountDiffIncremental(accountAddr, accountDiff, sd, updatedAccountAction)
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
updatedAccountRows = append(updatedAccountRows, formattedAccountData) updatedAccountRows = append(updatedAccountRows, formattedAccountData)
} }
@ -78,8 +80,8 @@ func accumulateUpdatedAccountRows(sd builder.StateDiff) [][]string {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
func accumulateDeletedAccountRows(sd builder.StateDiff) [][]string { func accumulateDeletedAccountRows(sd builder.StateDiff) [][]string {
var deletedAccountRows [][]string var deletedAccountRows [][]string
for _, accountDiff := range sd.DeletedAccounts { for accountAddr, accountDiff := range sd.DeletedAccounts {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
formattedAccountData := formatAccountDiffEventual(accountDiff, sd, deletedAccountAction) formattedAccountData := formatAccountDiffEventual(accountAddr, accountDiff, sd, deletedAccountAction)
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
deletedAccountRows = append(deletedAccountRows, formattedAccountData) deletedAccountRows = append(deletedAccountRows, formattedAccountData)
} }
@ -89,8 +91,8 @@ func accumulateDeletedAccountRows(sd builder.StateDiff) [][]string {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
func accumulateCreatedAccountRows(sd builder.StateDiff) [][]string { func accumulateCreatedAccountRows(sd builder.StateDiff) [][]string {
var createdAccountRows [][]string var createdAccountRows [][]string
for _, accountDiff := range sd.CreatedAccounts { for accountAddr, accountDiff := range sd.CreatedAccounts {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
formattedAccountData := formatAccountDiffEventual(accountDiff, sd, createdAccountAction) formattedAccountData := formatAccountDiffEventual(accountAddr, accountDiff, sd, createdAccountAction)
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
createdAccountRows = append(createdAccountRows, formattedAccountData) createdAccountRows = append(createdAccountRows, formattedAccountData)
} }
@ -98,10 +100,12 @@ func accumulateCreatedAccountRows(sd builder.StateDiff) [][]string {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
return createdAccountRows return createdAccountRows
} }
func formatAccountDiffEventual(accountDiff builder.AccountDiff, sd builder.StateDiff, accountAction string) []string { func formatAccountDiffEventual(accountAddr common.Address, accountDiff builder.AccountDiff, sd builder.StateDiff, accountAction string) []string {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
newContractRoot := accountDiff.ContractRoot.Value newContractRoot := accountDiff.ContractRoot.Value
var storageDiffPaths []string var storageDiffPaths []string
for k := range accountDiff.Storage { var storageValue builder.DiffString
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
for k, v := range accountDiff.Storage {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
storageValue = v
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
storageDiffPaths = append(storageDiffPaths, k) storageDiffPaths = append(storageDiffPaths, k)
} }
formattedAccountData := []string{ formattedAccountData := []string{
@ -113,15 +117,19 @@ func formatAccountDiffEventual(accountDiff builder.AccountDiff, sd builder.State
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
accountDiff.Balance.Value.String(), accountDiff.Balance.Value.String(),
*newContractRoot, *newContractRoot,
strings.Join(storageDiffPaths, ","), strings.Join(storageDiffPaths, ","),
accountAddr.String(),
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
*storageValue.Value,
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
} }
return formattedAccountData return formattedAccountData
} }
func formatAccountDiffIncremental(accountDiff builder.AccountDiff, sd builder.StateDiff, accountAction string) []string { func formatAccountDiffIncremental(accountAddr common.Address, accountDiff builder.AccountDiff, sd builder.StateDiff, accountAction string) []string {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
newContractRoot := accountDiff.ContractRoot.Value newContractRoot := accountDiff.ContractRoot.Value
var storageDiffPaths []string var storageDiffPaths []string
for k := range accountDiff.Storage { var storageValue builder.DiffString
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
for k, v := range accountDiff.Storage {
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
storageDiffPaths = append(storageDiffPaths, k) storageDiffPaths = append(storageDiffPaths, k)
storageValue = v
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
} }
formattedAccountData := []string{ formattedAccountData := []string{
strconv.FormatInt(sd.BlockNumber, 10), strconv.FormatInt(sd.BlockNumber, 10),
@ -132,6 +140,8 @@ func formatAccountDiffIncremental(accountDiff builder.AccountDiff, sd builder.St
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
accountDiff.Balance.Value.String(), accountDiff.Balance.Value.String(),
*newContractRoot, *newContractRoot,
strings.Join(storageDiffPaths, ","), strings.Join(storageDiffPaths, ","),
accountAddr.String(),
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
*storageValue.Value,
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
} }
return formattedAccountData return formattedAccountData
} }

rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:00:34 +00:00 (Migrated from github.com)
Review
Copy Link

And then I think the _ here could be captured to publish the address

And then I think the `_` here could be captured to publish the address
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
rmulhol commented 2019-01-03 23:05:31 +00:00 (Migrated from github.com)
Review
Copy Link

I'm a little confused about how this works - isn't accountDiff.Storage a map? Does k capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data

I'm a little confused about how this works - isn't `accountDiff.Storage` a map? Does `k` capture the key and value? Thinking we probably want both of those so that we can parse the new value and associate it with the corresponding key when consuming the data
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌
elizabethengelman commented 2019-01-10 19:33:36 +00:00 (Migrated from github.com)
Review
Copy Link

Yep, good call - k is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

Yep, good call - `k` is just capturing the path to the storage value. I think I'll want both the key and the value when I add the storage value to the csv 👌

6
statediff/publisher/publisher_test.go
View File

@ -34,6 +34,8 @@ var expectedCreatedAccountRow = []string{
strconv.FormatInt(testhelpers.NewBalanceValue, 10), strconv.FormatInt(testhelpers.NewBalanceValue, 10),
testhelpers.ContractRoot, testhelpers.ContractRoot,
testhelpers.StoragePath, testhelpers.StoragePath,
testhelpers.ContractAddress,
testhelpers.StorageValue,
} }
var expectedUpdatedAccountRow = []string{ var expectedUpdatedAccountRow = []string{
@ -45,6 +47,8 @@ var expectedUpdatedAccountRow = []string{
strconv.FormatInt(testhelpers.NewBalanceValue, 10), strconv.FormatInt(testhelpers.NewBalanceValue, 10),
testhelpers.ContractRoot, testhelpers.ContractRoot,
testhelpers.StoragePath, testhelpers.StoragePath,
testhelpers.ContractAddress,
testhelpers.StorageValue,
} }
var expectedDeletedAccountRow = []string{ var expectedDeletedAccountRow = []string{
@ -56,6 +60,8 @@ var expectedDeletedAccountRow = []string{
strconv.FormatInt(testhelpers.NewBalanceValue, 10), strconv.FormatInt(testhelpers.NewBalanceValue, 10),
testhelpers.ContractRoot, testhelpers.ContractRoot,
testhelpers.StoragePath, testhelpers.StoragePath,
testhelpers.ContractAddress,
testhelpers.StorageValue,
} }
func TestPublisher(t *testing.T) { func TestPublisher(t *testing.T) {

5
statediff/testhelpers/test_data.go
View File

@ -15,9 +15,10 @@ var (
NewBalanceValue = rand.Int63() NewBalanceValue = rand.Int63()
ContractRoot = "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421" ContractRoot = "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421"
StoragePath = "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470" StoragePath = "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470"
newStorage = "0x03" StorageValue = "0x03"
storage = map[string]builder.DiffString{StoragePath: {Value: &newStorage}} storage = map[string]builder.DiffString{StoragePath: {Value: &StorageValue}}
address = common.HexToAddress("0xaE9BEa628c4Ce503DcFD7E305CaB4e29E7476592") address = common.HexToAddress("0xaE9BEa628c4Ce503DcFD7E305CaB4e29E7476592")
ContractAddress = address.String()
CreatedAccountDiffs = map[common.Address]builder.AccountDiff{address: { CreatedAccountDiffs = map[common.Address]builder.AccountDiff{address: {
Nonce: builder.DiffUint64{Value: &NewNonceValue}, Nonce: builder.DiffUint64{Value: &NewNonceValue},
Balance: builder.DiffBigInt{Value: big.NewInt(NewBalanceValue)}, Balance: builder.DiffBigInt{Value: big.NewInt(NewBalanceValue)},