cerc-io/go-ethereum
12
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Statediffing #7

Closed
elizabethengelman wants to merge 17 commits from statediffing into master
pull from: statediffing
merge into: :master
Conversation 1 Commits 17 Files Changed 88
+7083 -34
elizabethengelman commented 2019-02-21 20:44:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Opening this PR as a reference. This is the main branch for Vulcanize's statediffing for an archive node. It has been rebased with https://github.com/ethereum/go-ethereum/releases/tag/v1.8.21

Please note that this diff is very large because the master branch isn't yet up-to-date with geth v1.8.21. To see just state diffing additions, start at commit 52274e48a101b9e1c838b327a2b5c6087ad87857 on Jan 28, 2019.

Opening this PR as a reference. This is the main branch for Vulcanize's statediffing for an archive node. It has been rebased with https://github.com/ethereum/go-ethereum/releases/tag/v1.8.21 Please note that this diff is very large because the master branch isn't yet up-to-date with geth v1.8.21. To see just state diffing additions, start at commit `52274e48a101b9e1c838b327a2b5c6087ad87857` on Jan 28, 2019.
elizabethengelman (Migrated from github.com) reviewed 2019-02-22 15:48:22 +00:00
statediff/service/service.go
elizabethengelman (Migrated from github.com) commented 2019-02-22 15:48:22 +00:00
Copy Link
Copy Source

This error message is a bit misleading - we should reword it so that it is clear that the process will be stopped if parentBlock == nil, and not just skipping that single block.

This error message is a bit misleading - we should reword it so that it is clear that the process will be stopped if `parentBlock == nil`, and not just skipping that single block.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
elizabethengelman
Labels
Clear labels
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#7