Support EIP-2930 #64
Labels
No Label
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/go-ethereum#64
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Firstly just assert we can index EIP-2930 txs as normal, without the additional fields/rows and with no issues in storing them as IPLDs.
Secondly, adjust the code and database schemas to decode and index the new access list.
We are running into error like this until we support it:
statediff.Service.WriteLoop: processing error block height=12323727 error="error creating IPLD nodes from block and receipts: wrong transaction hash computed" worker=8
This is because for 2930 txs it is not just the RLP encoded tx that is stored in the trie, but rather
0x01 || RLP(tx)
so theEncodeRLP()
method does not work any more and we need to useMarshalBinary()
.The same is true for receipts, except we need to add the
MarshalBinary()
method first.Addressed in #68
https://vulcanize.slack.com/archives/CGY8XDDNZ/p1620102149463900
I think we can close this now?