cerc-io/go-ethereum
18
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Statediff Prometheus metrics refactor #39

Merged
telackey merged 5 commits from statediff-prometheus into v1.9.24-statediff 2020-11-24 07:29:52 +00:00
Conversation 1 Commits 5 Files Changed 6 +169 -315
roysc commented 2020-11-16 10:26:27 +00:00
Member
Copy Link

Resolves https://github.com/vulcanize/go-ethereum/issues/36. (rebased onto https://github.com/vulcanize/go-ethereum/pull/38)

Note - the existing prometheus integration is basic and may not support the same metrics types we use - e.g. the DB blockedSeconds/WaitDuration feeds a float Counter, which is not implemented (I'm rounding to int - could implement it or do something hacky like add to a gauge).

To do:

  • decide how/how often to poll DB stats
  • naming (namespace & subsystem) for indexing & DB metrics
Resolves https://github.com/vulcanize/go-ethereum/issues/36. (rebased onto https://github.com/vulcanize/go-ethereum/pull/38) Note - the existing prometheus integration is basic and may not support the same metrics types we use - e.g. the DB `blockedSeconds`/`WaitDuration` feeds a float Counter, which is not implemented (I'm rounding to int - could implement it or do something hacky like add to a gauge). To do: - [x] decide how/how often to poll DB stats - [x] naming (namespace & subsystem) for indexing & DB metrics
roysc commented 2020-11-16 10:32:33 +00:00
Author
Member
Copy Link

Verified the metrics output shows up at /debug/metrics, per https://blog.ethereum.org/2019/07/10/geth-v1-9-0/

Verified the metrics output shows up at `/debug/metrics`, per https://blog.ethereum.org/2019/07/10/geth-v1-9-0/
i-norden requested changes 2020-11-16 13:12:30 +00:00
i-norden left a comment
Member
Copy Link

Getting statediff/indexer/indexer.go:44:22: undefined: RegisterIndexerMetrics in the CI make build step

Getting `statediff/indexer/indexer.go:44:22: undefined: RegisterIndexerMetrics` in the CI make build step
i-norden approved these changes 2020-11-18 14:27:46 +00:00
i-norden left a comment
Member
Copy Link

LGTM, we will want to expose the latest sync height and statediff height over prometheus eventually but that can be a separate PR: https://github.com/vulcanize/supernode_ops/issues/24

LGTM, we will want to expose the latest sync height and statediff height over prometheus eventually but that can be a separate PR: https://github.com/vulcanize/supernode_ops/issues/24
Sign in to join this conversation.
Reviewers
No reviewers
i-norden
Labels
Clear labels   
bug

   
critical

   
duplicate

   
enhancement

   
epic

   
help wanted

   
in progress

   
invalid

   
low priority

   
question

   
rebase

   
v1

   
v5

   
wontfix
  
Copied from Github

An issue or PR manually copied from GitHub.

  
Kind/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#39
No description provided.
Delete Branch "statediff-prometheus"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?