expose parent path from trie.Iterator #368

i-norden · 2023-04-15T00:56:11Z

i-norden commented

2023-04-15 00:56:11 +00:00

Necessary in order to generate selector suffixes (paths) for embedded/internalized leaf nodes. See https://github.com/cerc-io/go-ethereum/issues/255.

i-norden commented

2023-05-11 01:21:27 +00:00

@AFDudley @roysc was hoping to avoid this because it changes the NodeIterator interface which will prevent us from using the pluggeth NodeIterator implementation, but it would also be very convenient for a fix to #376.

When we move to pluggeth we can maintain our own external interface and implementation of NodeIterator, since this is a purely additive change the original interface expected by pluggeth is still supported.

@AFDudley @roysc was hoping to avoid this because it changes the `NodeIterator` interface which will prevent us from using the pluggeth `NodeIterator` implementation, but it would also be very convenient for a fix to #376. When we move to pluggeth we can maintain our own external interface and implementation of `NodeIterator`, since this is a purely additive change the original interface expected by pluggeth is still supported.

👍 1

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#368