cerc-io/go-ethereum
12
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Fix and test WriteStateDiffAt #358

Merged
telackey merged 4 commits from roy/v5-dev into v1.11.5-statediff-v5 2023-04-05 15:22:33 +00:00
Conversation 1 Commits 4 Files Changed 5
+132 -19
roysc commented 2023-04-05 12:58:14 +00:00
Owner
Copy Link
Copy Source

Make the JobStatus fields public so it's actually usable; fix and add a basic unit test for the method.

Resolves https://github.com/cerc-io/go-ethereum/issues/355
See https://github.com/cerc-io/go-ethereum/issues/356#issuecomment-1493438343

Port of https://github.com/cerc-io/go-ethereum/pull/357 to v5

Make the `JobStatus` fields public so it's actually usable; fix and add a basic unit test for the method. Resolves https://github.com/cerc-io/go-ethereum/issues/355 See https://github.com/cerc-io/go-ethereum/issues/356#issuecomment-1493438343 Port of https://github.com/cerc-io/go-ethereum/pull/357 to v5
i-norden approved these changes 2023-04-05 15:21:25 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
Labels
Clear labels
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#358