Async WriteStateDiffFor
#356
Labels
No Label
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
Kind/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cerc-io/go-ethereum#356
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In https://github.com/cerc-io/go-ethereum/pull/306
WriteStateDiffAt
was made async and now returns aJobID
whose progress can be monitored with theStreamWrites
endpoint now, butWriteStateDiffFor
is still using the old sync pattern. This should be a quick patch and done at the same time as #355Included in this issue, we need to add test coverage for the changes in https://github.com/cerc-io/go-ethereum/pull/306 and the new changes here.
It seems the async method + streamWrites is broken, see CICD history on this PR: https://github.com/cerc-io/eth-statediff-fill-service/pull/16
Can get tests to pass by using the sync
WriteStateDiffFor
method, but not with asyncWriteStateDiffAt
usingStreamWrites
to wait for completion.I may also have made a mistake on the subscriber side.