Async WriteStateDiffFor #356

Open
opened 2023-04-02 19:44:23 +00:00 by i-norden · 1 comment
Member

In https://github.com/cerc-io/go-ethereum/pull/306 WriteStateDiffAt was made async and now returns a JobID whose progress can be monitored with the StreamWrites endpoint now, but WriteStateDiffFor is still using the old sync pattern. This should be a quick patch and done at the same time as #355

Included in this issue, we need to add test coverage for the changes in https://github.com/cerc-io/go-ethereum/pull/306 and the new changes here.

In https://github.com/cerc-io/go-ethereum/pull/306 `WriteStateDiffAt` was made async and now returns a `JobID` whose progress can be monitored with the `StreamWrites` endpoint now, but `WriteStateDiffFor` is still using the old sync pattern. This should be a quick patch and done at the same time as #355 Included in this issue, we need to add test coverage for the changes in https://github.com/cerc-io/go-ethereum/pull/306 and the new changes here.
Author
Member

It seems the async method + streamWrites is broken, see CICD history on this PR: https://github.com/cerc-io/eth-statediff-fill-service/pull/16

Can get tests to pass by using the sync WriteStateDiffFor method, but not with async WriteStateDiffAt using StreamWrites to wait for completion.

I may also have made a mistake on the subscriber side.

It seems the async method + streamWrites is broken, see CICD history on this PR: https://github.com/cerc-io/eth-statediff-fill-service/pull/16 Can get tests to pass by using the sync `WriteStateDiffFor` method, but not with async `WriteStateDiffAt` using `StreamWrites` to wait for completion. I may also have made a mistake on the subscriber side.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#356
No description provided.