v5 additions #345

roysc · 2023-03-21T17:25:13Z

roysc commented

2023-03-21 17:25:13 +00:00

Main additions -

using the schema tables to generate postgres inserts, in addition to CSV files;
split out Connect{SQLX, PGX} convenience funcs for external use

Main additions - - using the schema tables to generate postgres inserts, in addition to CSV files; - split out `Connect{SQLX, PGX}` convenience funcs for external use

❤️ 1

i-norden approved these changes 2023-03-21 17:58:39 +00:00

i-norden left a comment

LGTM, I appreciate the decoupling of the public.nodes initialization from the database driver/pool initialization. This gets us closer to having a single shared SQL database abstraction we can use here and elsewhere like in ipld-eth-statedb a la https://github.com/cerc-io/go-ethereum/issues/204

LGTM, I appreciate the decoupling of the `public.nodes` initialization from the database driver/pool initialization. This gets us closer to having a single shared SQL database abstraction we can use here and elsewhere like in ipld-eth-statedb a la https://github.com/cerc-io/go-ethereum/issues/204

i-norden commented

2023-03-21 20:30:39 +00:00

Going to merge this in so I can continue working on-top of it. Will create an issue to add some more unit tests.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#345