cerc-io/go-ethereum
12
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

EIP1559 #31

Merged
ramilexe merged 16 commits from 1559_rework into 1559_test 2020-11-05 12:09:04 +00:00
Conversation 4 Commits 16 Files Changed 25
+396 -396
ramilexe commented 2020-10-26 13:42:44 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
ramilexe commented 2020-10-26 13:43:39 +00:00 (Migrated from github.com)
Copy Link
Copy Source
  • RPC refarctored
  • updated base classes
* RPC refarctored * updated base classes
cmd/geth/misccmd.go
i-norden commented 2020-11-04 17:47:26 +00:00
Member
Copy Link
Copy Source

I think we should add this info to the version meta in addition to (or instead of) here

I think we should add this info to the [version meta](https://github.com/vulcanize/go-ethereum/blob/1559_rework/params/version.go#L27) in addition to (or instead of) here
core/types/transaction.go
i-norden commented 2020-11-04 17:49:48 +00:00
Member
Copy Link
Copy Source

New JSON tags here and in other files should use camelCase

New JSON tags here and in other files should use camelCase
n0cte (Migrated from github.com) reviewed 2020-11-04 18:45:20 +00:00
cmd/geth/misccmd.go
n0cte (Migrated from github.com) commented 2020-11-04 18:45:20 +00:00
Copy Link
Copy Source
VersionMeta  = "eip1559-970c594cd3"
``` VersionMeta = "eip1559-970c594cd3" ```
n0cte (Migrated from github.com) reviewed 2020-11-04 18:47:05 +00:00
core/types/transaction.go
n0cte (Migrated from github.com) commented 2020-11-04 18:47:05 +00:00
Copy Link
Copy Source

max_miner_bribe_per_gas changed to maxMinerBribePerGas
fee_cap_per_gas changed to feeCapPerGas

```max_miner_bribe_per_gas``` changed to ``` maxMinerBribePerGas``` ```fee_cap_per_gas``` changed to ``` feeCapPerGas```
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
n0cte
Labels
Clear labels
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#31