cerc-io/go-ethereum
12
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Change WriteStateDiffAt to async #306

Merged
telackey merged 1 commits from roy/async-writestatediffat into v1.10.26-statediff-v4 2023-01-18 15:40:17 +00:00
Conversation 2 Commits 1 Files Changed 3
+140 -87
roysc commented 2023-01-13 03:55:39 +00:00
Owner
Copy Link
Copy Source
  • Changes WriteStateDiffAt to immediately return an integer job ID and process the write asynchronously
  • introduces a StreamWrites subscription endpoint to the API to listen for results

Partial solution for https://github.com/cerc-io/go-ethereum/issues/296

- Changes `WriteStateDiffAt` to immediately return an integer job ID and process the write asynchronously - introduces a `StreamWrites` subscription endpoint to the API to listen for results Partial solution for https://github.com/cerc-io/go-ethereum/issues/296
🎉 1
i-norden left a comment
Member
Copy Link
Copy Source

Looking good, left a comment and we should add some test coverage that captures these changes. The entire api.go needs test coverage but I don't want to tack that on here so we can create a separate issue for that.

Looking good, left a comment and we should add some test coverage that captures these changes. The entire `api.go` needs test coverage but I don't want to tack that on here so we can create a separate issue for that.
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
roysc
Labels
Clear labels
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#306