Implement delayed Tx #295

roysc · 2023-01-02T21:14:51Z

roysc commented

2023-01-02 21:14:51 +00:00

Implements a Tx object that caches SQL statements, then builds and commits the underlying transaction at Commit.

Closes https://github.com/cerc-io/go-ethereum/issues/294

Implements a `Tx` object that caches SQL statements, then builds and commits the underlying transaction at `Commit`. Closes https://github.com/cerc-io/go-ethereum/issues/294

❤️ 1

i-norden reviewed 2023-01-03 15:46:39 +00:00

i-norden left a comment

Nice! Could you retarget this to https://github.com/cerc-io/go-ethereum/tree/v1.10.26-statediff-v4?

How difficult would it be to add some basic benchmarks to this? We could potentially reuse some of the test ChainMaker chains used in builder.go.

Nice! Could you retarget this to https://github.com/cerc-io/go-ethereum/tree/v1.10.26-statediff-v4? How difficult would it be to add some basic benchmarks to this? We could potentially reuse some of the test ChainMaker chains used in builder.go.

i-norden reviewed 2023-01-04 16:15:22 +00:00

i-norden reviewed 2023-01-04 16:35:26 +00:00

roysc reviewed 2023-01-04 17:12:16 +00:00

roysc commented

2023-01-06 07:38:43 +00:00

Finally fixed after a few rabbit holes 🙄

i-norden approved these changes 2023-01-06 17:31:34 +00:00

i-norden left a comment

Thanks for the quick turn around, LGTM, let's go ahead and merge this and cut a release so we can test it in a mainnet env.

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#295