Vdb 833 more robust statediffing tests #15

i-norden · 2019-09-18T17:19:48Z

elizabethengelman commented

2019-09-18 17:19:48 +00:00

(Migrated from github.com)

Updated the contract that's being used to test the statediffing work. The biggest change is that TestContract now has different data types in it's storage: bytes32, address, uint48, uint256[10], mapping(uint => TestStruct).

Note: I was having trouble calculating the TestStruct storage key earlier, but I think it was a silly mistake that I figured out, and it is now working. i.e. common.HexToHash(“3”) !=common.Hex2Bytes(“03”) != common.Hex2Bytes(“3”) 🤦‍♀

This should be ready for review finally! 😅

Updated the contract that's being used to test the statediffing work. The biggest change is that `TestContract` now has different data types in it's storage: bytes32, address, uint48, uint256[10], mapping(uint => TestStruct). _Note:_ I was having trouble calculating the TestStruct storage key earlier, but I think it was a silly mistake that I figured out, and it is now working. i.e. common.HexToHash(“3”) !=common.Hex2Bytes(“03”) != common.Hex2Bytes(“3”) 🤦‍♀ This should be ready for review finally! 😅

aaizuss (Migrated from github.com) reviewed 2019-09-18 17:19:48 +00:00

Gslaughl (Migrated from github.com) reviewed 2019-09-18 17:19:48 +00:00

m0ar (Migrated from github.com) reviewed 2019-09-18 17:19:48 +00:00

rmulhol (Migrated from github.com) reviewed 2019-09-18 17:19:48 +00:00

yaoandrew (Migrated from github.com) reviewed 2019-09-18 17:19:48 +00:00

i-norden approved these changes 2019-09-20 23:48:22 +00:00

i-norden left a comment

LGTM! Thanks for improving these tests :)

i-norden reviewed 2019-09-20 23:54:01 +00:00

statediff/builder_test.go

						
				@ -74,3 +88,4 @@

					burnAccountBlock1, _ = rlp.EncodeToBytes(state.Account{

						Nonce:    nonce0,

						Balance:  big.NewInt(miningReward),

						CodeHash: common.HexToHash("0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470").Bytes(),