cerc-io/go-ethereum
12
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Create a seperate table for storing logs. #102

Merged
arijitAD merged 2 commits from log-table into v1.10.8-statediff 2021-08-27 07:20:09 +00:00
Conversation 30 Commits 2 Files Changed 23
+762 -207
arijitAD commented 2021-08-05 05:32:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
i-norden left a comment
Member
Copy Link
Copy Source

Need to make some changes to the db schema, which will necessitate updating the go code some too, but otherwise everything looks great (and would work for the current schema).

Need to make some changes to the db schema, which will necessitate updating the go code some too, but otherwise everything looks great (and would work for the current schema).
ashwinphatak (Migrated from github.com) reviewed 2021-08-11 05:59:23 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:35 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:39 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:44 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:52 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:57 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:02 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:05 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:34 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:38 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:41 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:52 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:55 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-16 12:57:05 +00:00
i-norden approved these changes 2021-08-18 12:43:18 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

LGTM, just one or two minor tweaks and then there are a few things still open to discussion. I'll bring these things up in slack and we can figure out what the best approach is.

LGTM, just one or two minor tweaks and then there are a few things still open to discussion. I'll bring these things up in slack and we can figure out what the best approach is.
ashwinphatak (Migrated from github.com) reviewed 2021-08-20 05:21:39 +00:00
ashwinphatak (Migrated from github.com) reviewed 2021-08-20 05:40:53 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-23 16:42:48 +00:00
i-norden left a comment
Member
Copy Link
Copy Source

Thanks Arijit, this is looking good. A few comments, nothing major. But I'm curious if we have proper unit test coverage for the indexing of the logs table- tests that include the new mh_key and cid rows? I don't see it in this diff, might have missed it.

Thanks Arijit, this is looking good. A few comments, nothing major. But I'm curious if we have proper unit test coverage for the indexing of the logs table- tests that include the new `mh_key` and `cid` rows? I don't see it in this diff, might have missed it.
i-norden approved these changes 2021-08-24 02:18:37 +00:00
ashwinphatak (Migrated from github.com) reviewed 2021-08-24 05:24:52 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-24 10:05:31 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-24 10:07:27 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-24 10:07:49 +00:00
arijitAD (Migrated from github.com) reviewed 2021-08-24 10:09:29 +00:00
ashwinphatak (Migrated from github.com) approved these changes 2021-08-24 10:56:04 +00:00
arijitAD commented 2021-08-24 11:41:32 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Will merge this PR once we have a major release https://github.com/vulcanize/go-ethereum/pull/107

Will merge this PR once we have a major release https://github.com/vulcanize/go-ethereum/pull/107
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
arijitAD
ashwinphatak
Labels
Clear labels
bug
critical
duplicate
enhancement
epic
help wanted
in progress
invalid
low priority
question
rebase
v1
v5
wontfix
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley (A. F. Dudley) Alex ashwin cerccicd ericlewis i-norden (Ian Norden) prathamesh (Prathamesh Musale) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw (srw) zramsay
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#102