Create a seperate table for storing logs. #102

i-norden · 2021-08-05T05:32:06Z

arijitAD commented

2021-08-05 05:32:06 +00:00

(Migrated from github.com)

No description provided.

i-norden requested changes 2021-08-11 05:11:34 +00:00

i-norden left a comment

Need to make some changes to the db schema, which will necessitate updating the go code some too, but otherwise everything looks great (and would work for the current schema).

ashwinphatak (Migrated from github.com) reviewed 2021-08-11 05:59:23 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:35 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:39 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:44 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:52 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:55:57 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:02 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:05 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:34 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:38 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:41 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:52 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:56:55 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-16 12:57:05 +00:00

i-norden approved these changes 2021-08-18 12:43:18 +00:00

i-norden left a comment

LGTM, just one or two minor tweaks and then there are a few things still open to discussion. I'll bring these things up in slack and we can figure out what the best approach is.

i-norden reviewed 2021-08-18 12:44:33 +00:00

i-norden requested changes 2021-08-20 01:54:27 +00:00

ashwinphatak (Migrated from github.com) reviewed 2021-08-20 05:21:39 +00:00

ashwinphatak (Migrated from github.com) reviewed 2021-08-20 05:40:53 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-23 16:42:48 +00:00

i-norden reviewed 2021-08-24 02:14:27 +00:00

i-norden left a comment

Thanks Arijit, this is looking good. A few comments, nothing major. But I'm curious if we have proper unit test coverage for the indexing of the logs table- tests that include the new mh_key and cid rows? I don't see it in this diff, might have missed it.

Thanks Arijit, this is looking good. A few comments, nothing major. But I'm curious if we have proper unit test coverage for the indexing of the logs table- tests that include the new `mh_key` and `cid` rows? I don't see it in this diff, might have missed it.

i-norden approved these changes 2021-08-24 02:18:37 +00:00

ashwinphatak (Migrated from github.com) reviewed 2021-08-24 05:24:52 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-24 10:05:31 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-24 10:07:27 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-24 10:07:49 +00:00

arijitAD (Migrated from github.com) reviewed 2021-08-24 10:09:29 +00:00

ashwinphatak (Migrated from github.com) approved these changes 2021-08-24 10:56:04 +00:00

arijitAD commented

2021-08-24 11:41:32 +00:00

(Migrated from github.com)

Will merge this PR once we have a major release https://github.com/vulcanize/go-ethereum/pull/107

Sign in to join this conversation.

No reviewers

ashwinphatak

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: cerc-io/go-ethereum#102