From a71b9b9ffad052210137b1c4d6014a40cfd1046a Mon Sep 17 00:00:00 2001
From: hero5512 <lvshuaino@gmail.com>
Date: Mon, 19 Jun 2023 01:52:40 -0400
Subject: [PATCH] core/txpool/legacypool: remove redundant check for
floatingRatio == 0 (#27477)
floatingRatio is a constant and always non-zero. So there is no need to
check for == 0.
---
core/txpool/legacypool/list.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/core/txpool/legacypool/list.go b/core/txpool/legacypool/list.go
index d3b6768f8..d5d24c85a 100644
--- a/core/txpool/legacypool/list.go
+++ b/core/txpool/legacypool/list.go
@@ -590,7 +590,7 @@ func (l *pricedList) underpricedFor(h *priceHeap, tx *types.Transaction) bool {
func (l *pricedList) Discard(slots int, force bool) (types.Transactions, bool) {
drop := make(types.Transactions, 0, slots) // Remote underpriced transactions to drop
for slots > 0 {
- if len(l.urgent.list)*floatingRatio > len(l.floating.list)*urgentRatio || floatingRatio == 0 {
+ if len(l.urgent.list)*floatingRatio > len(l.floating.list)*urgentRatio {
// Discard stale transactions if found during cleanup
tx := heap.Pop(&l.urgent).(*types.Transaction)
if l.all.GetRemote(tx.Hash()) == nil { // Removed or migrated