cerc-io/go-ethereum
13
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

Remove the need to pass a transaction when upserting to known_gaps

Browse Source 
Thanks Ian :D
This commit is contained in:
Abdul Rabbani 2022-03-22 11:52:35 -04:00
parent bca12f9cdf
commit 73f46a59ef
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
statediff/indexer/database/sql/indexer.go
View File

@ -562,18 +562,8 @@ func (sdi *StateDiffIndexer) PushKnownGaps(startingBlockNumber *big.Int, endingB
CheckedOut: checkedOut,
ProcessingKey: processingKey,
}
tx, err := sdi.dbWriter.db.Begin(sdi.ctx)
if err != nil {
if err := sdi.dbWriter.upsertKnownGaps(knownGap); err != nil {
return err
}
if err := sdi.dbWriter.upsertKnownGaps(tx, knownGap); err != nil {
return err
}
if err := tx.Commit(sdi.ctx); err != nil {
return err
}
return nil
}

7
statediff/indexer/database/sql/writer.go
View File

@ -17,6 +17,7 @@
package sql
import (
"context"
"fmt"
"github.com/ethereum/go-ethereum/common"
@ -183,14 +184,12 @@ func (w *Writer) upsertStorageCID(tx Tx, storageCID models.StorageNodeModel) err
return nil
}
func (w *Writer) upsertKnownGaps(tx Tx, knownGaps models.KnownGapsModel) error {
res, err := tx.Exec(w.db.Context(), w.db.InsertKnownGapsStm(),
func (w *Writer) upsertKnownGaps(knownGaps models.KnownGapsModel) error {
_, err := w.db.Exec(context.Background(), w.db.InsertKnownGapsStm(),
knownGaps.StartingBlockNumber, knownGaps.EndingBlockNumber, knownGaps.CheckedOut, knownGaps.ProcessingKey)
if err != nil {
return fmt.Errorf("error upserting known_gaps entry: %v", err)
}
ret, _ := res.RowsAffected()
fmt.Println("Res:", ret)
return nil
}