From 72a47729bbd4b73b55a678d52668a7c19a8a0a50 Mon Sep 17 00:00:00 2001 From: Roy Crihfield Date: Tue, 24 Nov 2020 18:19:39 +0800 Subject: [PATCH] metrics namespace/subsystem = statediff/{indexer,service} --- statediff/indexer/metrics.go | 8 ++++---- statediff/metrics.go | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/statediff/indexer/metrics.go b/statediff/indexer/metrics.go index 5ee3426a3..fc0727eda 100644 --- a/statediff/indexer/metrics.go +++ b/statediff/indexer/metrics.go @@ -8,7 +8,7 @@ import ( ) const ( - indexerNamespace = "indexer" + namespace = "statediff" ) // Build a fully qualified metric name @@ -16,9 +16,9 @@ func metricName(subsystem, name string) string { if name == "" { return "" } - parts := []string{indexerNamespace, name} + parts := []string{namespace, name} if subsystem != "" { - parts = []string{indexerNamespace, subsystem, name} + parts = []string{namespace, subsystem, name} } // Prometheus uses _ but geth metrics uses / and replaces return strings.Join(parts, "/") @@ -57,7 +57,7 @@ func RegisterIndexerMetrics(reg metrics.Registry) indexerMetricsHandles { tTxAndRecProcessing: metrics.NewTimer(), tStateStoreCodeProcessing: metrics.NewTimer(), } - subsys := "" // todo + subsys := "indexer" reg.Register(metricName(subsys, "blocks"), ctx.blocks) reg.Register(metricName(subsys, "transactions"), ctx.transactions) reg.Register(metricName(subsys, "receipts"), ctx.receipts) diff --git a/statediff/metrics.go b/statediff/metrics.go index d75c583a0..7e7d6e328 100644 --- a/statediff/metrics.go +++ b/statediff/metrics.go @@ -44,7 +44,7 @@ func RegisterStatediffMetrics(reg metrics.Registry) statediffMetricsHandles { serviceLoopChannelLen: metrics.NewGauge(), writeLoopChannelLen: metrics.NewGauge(), } - subsys := "" // todo + subsys := "service" reg.Register(metricName(subsys, "last_sync_height"), ctx.lastSyncHeight) reg.Register(metricName(subsys, "last_event_height"), ctx.lastEventHeight) reg.Register(metricName(subsys, "last_statediff_height"), ctx.lastStatediffHeight)