diff --git a/statediff/publisher/publisher_test.go b/statediff/publisher/publisher_test.go index 5a3b8c857..12b19dff9 100644 --- a/statediff/publisher/publisher_test.go +++ b/statediff/publisher/publisher_test.go @@ -22,6 +22,7 @@ var ( publisher p.Publisher dir string err error + testFailedFormatString = "Test failed: %s, %+v" ) var expectedCreatedAccountRow = []string{ @@ -86,43 +87,46 @@ func TestPublisher(t *testing.T) { for _, test := range tests { test(t) - removeFilesFromDir(dir, t) + err := removeFilesFromDir(dir) + if err != nil { + t.Error("Error removing files from temp dir: %s", dir) + } } } -func removeFilesFromDir(dir string, t *testing.T) { +func removeFilesFromDir(dir string,) error { files, err := filepath.Glob(filepath.Join(dir, "*")) if err != nil { - t.Error() + return err } for _, file := range files { err = os.RemoveAll(file) if err != nil { - t.Error() + return err } } + return nil } func testColumnHeaders(t *testing.T) { _, err = publisher.PublishStateDiff(&testhelpers.TestStateDiff) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } file, err := getTestDiffFile(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } lines, err := csv.NewReader(file).ReadAll() if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } - if len(lines) <= 1 { - t.Error() + if len(lines) < 1 { + t.Errorf(testFailedFormatString, t.Name(), err) } - if !equals(lines[0], p.Headers) { t.Error() } @@ -132,51 +136,52 @@ func testAccountDiffs(t *testing.T) { // it persists the created, updated and deleted account diffs to a CSV file _, err = publisher.PublishStateDiff(&testhelpers.TestStateDiff) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } file, err := getTestDiffFile(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } lines, err := csv.NewReader(file).ReadAll() if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } if len(lines) <= 3 { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(lines[1], expectedCreatedAccountRow) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(lines[2], expectedUpdatedAccountRow) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(lines[3], expectedDeletedAccountRow) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } } func testWhenNoDiff(t *testing.T) { - //it creates an empty CSV when there is no diff", func() { + //it creates an empty CSV when there is no diff emptyDiff := builder.StateDiff{} _, err = publisher.PublishStateDiff(&emptyDiff) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } file, err := getTestDiffFile(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } lines, err := csv.NewReader(file).ReadAll() if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } + if !equals(len(lines), 1) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } } @@ -185,28 +190,28 @@ func testDefaultPublisher(t *testing.T) { config := statediff.Config{Path: dir} publisher, err = p.NewPublisher(config) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } _, err = publisher.PublishStateDiff(&testhelpers.TestStateDiff) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } file, err := getTestDiffFile(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } lines, err := csv.NewReader(file).ReadAll() if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(len(lines), 4) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(lines[0], p.Headers) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } } @@ -215,33 +220,33 @@ func testDefaultDirectory(t *testing.T) { config := statediff.Config{} publisher, err = p.NewPublisher(config) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } err := os.Chdir(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } _, err = publisher.PublishStateDiff(&testhelpers.TestStateDiff) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } file, err := getTestDiffFile(dir) if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } lines, err := csv.NewReader(file).ReadAll() if err != nil { - t.Error(err) + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(len(lines), 4) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } if !equals(lines[0], p.Headers) { - t.Error() + t.Errorf(testFailedFormatString, t.Name(), err) } } diff --git a/statediff/service/service_test.go b/statediff/service/service_test.go index 97a4a0c97..0025239af 100644 --- a/statediff/service/service_test.go +++ b/statediff/service/service_test.go @@ -58,16 +58,19 @@ func testServiceLoop(t *testing.T) { //parent and current blocks are passed to the extractor expectedCurrentBlocks := []types.Block{*block1, *block2} if !reflect.DeepEqual(extractor.CurrentBlocks, expectedCurrentBlocks) { - t.Errorf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", extractor.CurrentBlocks, expectedCurrentBlocks) + t.Error("Test failure:", t.Name()) + t.Logf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", extractor.CurrentBlocks, expectedCurrentBlocks) } expectedParentBlocks := []types.Block{*parentBlock1, *parentBlock2} if !reflect.DeepEqual(extractor.ParentBlocks, expectedParentBlocks) { - t.Errorf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", extractor.CurrentBlocks, expectedParentBlocks) + t.Error("Test failure:", t.Name()) + t.Logf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", extractor.CurrentBlocks, expectedParentBlocks) } //look up the parent block from its hash expectedHashes := []common.Hash{block1.ParentHash(), block2.ParentHash()} if !reflect.DeepEqual(blockChain.ParentHashesLookedUp, expectedHashes) { - t.Errorf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", blockChain.ParentHashesLookedUp, expectedHashes) + t.Error("Test failure:", t.Name()) + t.Logf("Actual does not equal expected.\nactual:%+v\nexpected: %+v", blockChain.ParentHashesLookedUp, expectedHashes) } }